Wasmtime GitHub notifications bot (Jun 16 2020 at 05:45): Wasmtime GitHub notifications bot (Jun 16 2020 at 05:45):jlb6740 edited PR #1797 from vcode-mul-div-max-min to master:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 16 2020 at 07:24):jlb6740 submitted PR Review.
Wasmtime GitHub notifications bot (Jun 16 2020 at 07:24):jlb6740 created PR Review Comment:
Been offline the last few days .. Thanks for the update. I looked into expand_minmax and at first glance I wasn't what needed to be done here so I've simply removed the min/max and will push support in another patch.
Wasmtime GitHub notifications bot (Jun 16 2020 at 07:29):jlb6740 updated PR #1797 from vcode-mul-div-max-min to master:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 16 2020 at 23:38):jlb6740 requested bnjbvr for a review on PR #1797.
Wasmtime GitHub notifications bot (Jun 17 2020 at 13:25):bnjbvr submitted PR Review.
Wasmtime GitHub notifications bot (Jun 17 2020 at 13:25):bnjbvr submitted PR Review.
Wasmtime GitHub notifications bot (Jun 17 2020 at 13:25):bnjbvr created PR Review Comment:
Can you please add a test for sqrtss, since its emission code is filled in this PR?
Wasmtime GitHub notifications bot (Jun 17 2020 at 13:25):bnjbvr created PR Review Comment:
I just realized we could in theory just suppress this
to_stringfunction, since theSseOpcodestruct implementsToString(with all the existing variants implemented).
Wasmtime GitHub notifications bot (Jun 17 2020 at 22:01):jlb6740 submitted PR Review.
Wasmtime GitHub notifications bot (Jun 17 2020 at 22:01):jlb6740 created PR Review Comment:
@bnjbvr .. By suppress do you mean to just delete this function with this patch? I did comment it out and so no issues in testing or running a simple example. Not sure if the lowercase could come into place somewhere, but I can delete this since it doesn't appear to be necessary.
Wasmtime GitHub notifications bot (Jun 17 2020 at 22:44):jlb6740 updated PR #1797 from vcode-mul-div-max-min to master:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 17 2020 at 22:46):jlb6740 updated PR #1797 from vcode-mul-div-max-min to master:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 17 2020 at 22:51):jlb6740 updated PR #1797 from vcode-mul-div-max-min to master:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 18 2020 at 00:19):jlb6740 merged PR #1797.
Wasmtime GitHub notifications bot (Jun 18 2020 at 10:01):bnjbvr submitted PR Review.
Wasmtime GitHub notifications bot (Jun 18 2020 at 10:01):bnjbvr created PR Review Comment:
Yes, that's what i meant, sorry for using unclear vocabulary. To wit: the
ToStringtrait implementation adds theto_stringfunction, maintaining feature completeness here.
Last updated: Oct 23 2024 at 20:03 UTC