jlb6740 edited PR #1797 from vcode-mul-div-max-min
to master
:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
jlb6740 submitted PR Review.
jlb6740 created PR Review Comment:
Been offline the last few days .. Thanks for the update. I looked into expand_minmax and at first glance I wasn't what needed to be done here so I've simply removed the min/max and will push support in another patch.
jlb6740 updated PR #1797 from vcode-mul-div-max-min
to master
:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
jlb6740 requested bnjbvr for a review on PR #1797.
bnjbvr submitted PR Review.
bnjbvr submitted PR Review.
bnjbvr created PR Review Comment:
Can you please add a test for sqrtss, since its emission code is filled in this PR?
bnjbvr created PR Review Comment:
I just realized we could in theory just suppress this
to_string
function, since theSseOpcode
struct implementsToString
(with all the existing variants implemented).
jlb6740 submitted PR Review.
jlb6740 created PR Review Comment:
@bnjbvr .. By suppress do you mean to just delete this function with this patch? I did comment it out and so no issues in testing or running a simple example. Not sure if the lowercase could come into place somewhere, but I can delete this since it doesn't appear to be necessary.
jlb6740 updated PR #1797 from vcode-mul-div-max-min
to master
:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
jlb6740 updated PR #1797 from vcode-mul-div-max-min
to master
:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
jlb6740 updated PR #1797 from vcode-mul-div-max-min
to master
:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
jlb6740 merged PR #1797.
bnjbvr submitted PR Review.
bnjbvr created PR Review Comment:
Yes, that's what i meant, sorry for using unclear vocabulary. To wit: the
ToString
trait implementation adds theto_string
function, maintaining feature completeness here.
Last updated: Dec 23 2024 at 13:07 UTC