Stream: git-wasmtime

Topic: wasmtime / PR #1776 Fix interpreter semantics of 'irsub_imm'

Wasmtime GitHub notifications bot (May 28 2020 at 03:26):

abrown requested fitzgen for a review on PR #1776.

Wasmtime GitHub notifications bot (May 28 2020 at 03:26):

abrown opened PR #1776 from fix-irsub-imm to master:

Previously the interpreter used arg - imm but the functionality should be a wrapping imm - arg (see cranelift/codegen/meta/src/shared/instructions.rs).

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (May 28 2020 at 14:28):

bnjbvr submitted PR Review.

Wasmtime GitHub notifications bot (May 28 2020 at 14:28):

bnjbvr merged PR #1776.

Last updated: Nov 22 2024 at 17:03 UTC