Stream: git-wasmtime

Topic: wasmtime / PR #1770 Make formats less SIMD-specific

Wasmtime GitHub notifications bot (May 29 2020 at 22:15):

abrown edited PR #1770 from binary-imm8 to master:

For consistency, this also renames BinaryImm to BinaryImm64. Like #1762, this is a re-factoring with no functionality change; however, users of Cranelift IR (e.g. @bjorn3, @jyn514?) might notice the change if they are using Format or InstructionData directly.

Wasmtime GitHub notifications bot (May 29 2020 at 22:19):

abrown edited PR #1770 from binary-imm8 to master:

This renames and slightly alters several formats:

• InsertLane becomes TernaryImm8
• ExtractLane becomes BinaryImm8
• BinaryImm becomes BinaryImm64 for consistency

This has additional comments in #1762 about the ordering of operands; in changing InsertLane to TernaryImm8 I changed the order of the operands in the CLIF IR (value, imm, value to value, value, imm) so that this format will make more sense for other instructions (x86_pshufd, x86_pblendw). Other than that this should be a straightforward renaming.

A heads up at the Cranelift API level: users of Cranelift IR (e.g. @bjorn3, @jyn514?) might notice this naming chaning if they are using Format or InstructionData directly.

Wasmtime GitHub notifications bot (May 29 2020 at 22:27):

iximeow submitted PR Review.

Wasmtime GitHub notifications bot (May 29 2020 at 22:28):

iximeow submitted PR Review.

Wasmtime GitHub notifications bot (May 30 2020 at 02:56):

abrown merged PR #1770.

Last updated: Dec 23 2024 at 12:05 UTC