Stream: git-wasmtime

Topic: wasmtime / PR #1767 Bump object to 0.19.0

view this post on Zulip Wasmtime GitHub notifications bot (May 27 2020 at 09:56):

bjorn3 opened PR #1767 from bump_object_to_0_19 to master:

All changes: https://github.com/gimli-rs/object/compare/0.18.0...0.19.0

Changes affecting the writing part of object:

https://github.com/gimli-rs/object/commit/6ee7638493b14d682c3eb689725976b7d4be6552 fixes the symbol class for undefined symbols when writing COFF files. (required for Windows support in cg_clif)
https://github.com/gimli-rs/object/commit/47856a29c847467d925713066781b9164a096d1d and https://github.com/gimli-rs/object/commit/59a2cb6b521c46dc251ec3bfaf181b4a83759fc4 add basic support for AArch64 ELF file writing. (required for AArch64 support in cg_clif)
https://github.com/gimli-rs/object/commit/5fccab91fde14638db1af78847477e8361354a66 removes the target-lexicon dependency.

view this post on Zulip Wasmtime GitHub notifications bot (May 27 2020 at 09:58):

bjorn3 updated PR #1767 from bump_object_to_0_19 to master:

All changes: https://github.com/gimli-rs/object/compare/0.18.0...0.19.0

Changes affecting the writing part of object:

https://github.com/gimli-rs/object/commit/6ee7638493b14d682c3eb689725976b7d4be6552 fixes the symbol class for undefined symbols when writing COFF files. (required for Windows support in cg_clif)
https://github.com/gimli-rs/object/commit/47856a29c847467d925713066781b9164a096d1d and https://github.com/gimli-rs/object/commit/59a2cb6b521c46dc251ec3bfaf181b4a83759fc4 add basic support for AArch64 ELF file writing. (required for AArch64 support in cg_clif)
https://github.com/gimli-rs/object/commit/5fccab91fde14638db1af78847477e8361354a66 removes the target-lexicon dependency.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 12 2020 at 14:11):

yurydelendik updated PR #1767 from bump_object_to_0_19 to master:

All changes: https://github.com/gimli-rs/object/compare/0.18.0...0.19.0

Changes affecting the writing part of object:

https://github.com/gimli-rs/object/commit/6ee7638493b14d682c3eb689725976b7d4be6552 fixes the symbol class for undefined symbols when writing COFF files. (required for Windows support in cg_clif)
https://github.com/gimli-rs/object/commit/47856a29c847467d925713066781b9164a096d1d and https://github.com/gimli-rs/object/commit/59a2cb6b521c46dc251ec3bfaf181b4a83759fc4 add basic support for AArch64 ELF file writing. (required for AArch64 support in cg_clif)
https://github.com/gimli-rs/object/commit/5fccab91fde14638db1af78847477e8361354a66 removes the target-lexicon dependency.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 12 2020 at 16:28):

bjorn3 submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 12 2020 at 16:28):

bjorn3 created PR Review Comment:

It would have been nice to deduplicate this, but I don't know of any suitable location.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 12 2020 at 16:28):

bjorn3 submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 12 2020 at 16:29):

bjorn3 submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 12 2020 at 16:34):

yurydelendik submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 12 2020 at 16:34):

yurydelendik created PR Review Comment:

Yeah, I noticed that as well. I'm keeping in mind possibility of using cranelift-object in wasmtime -- but let's see how my further refactorings will go.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 12 2020 at 18:07):

yurydelendik updated PR #1767 from bump_object_to_0_19 to master:

All changes: https://github.com/gimli-rs/object/compare/0.18.0...0.19.0

Changes affecting the writing part of object:

https://github.com/gimli-rs/object/commit/6ee7638493b14d682c3eb689725976b7d4be6552 fixes the symbol class for undefined symbols when writing COFF files. (required for Windows support in cg_clif)
https://github.com/gimli-rs/object/commit/47856a29c847467d925713066781b9164a096d1d and https://github.com/gimli-rs/object/commit/59a2cb6b521c46dc251ec3bfaf181b4a83759fc4 add basic support for AArch64 ELF file writing. (required for AArch64 support in cg_clif)
https://github.com/gimli-rs/object/commit/5fccab91fde14638db1af78847477e8361354a66 removes the target-lexicon dependency.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 12 2020 at 20:37):

yurydelendik merged PR #1767.

Last updated: Oct 23 2024 at 20:03 UTC