Stream: git-wasmtime

Topic: wasmtime / PR #1765 Implement fcvt_from_uint (i32x4 -> f3...

view this post on Zulip Wasmtime GitHub notifications bot (May 26 2020 at 22:32):

abrown opened PR #1765 from i32x4-to-f32x4 to master:

This converts an i32x4 into an f32x4 with some rounding either by using an AVX512VL/F instruction--VCVTUDQ2PS--or a long sequence of SSE4.1 compatible instructions.

It is still a draft as it depends on some commits in #1759.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 01 2020 at 16:07):

abrown updated PR #1765 from i32x4-to-f32x4 to master:

This converts an i32x4 into an f32x4 with some rounding either by using an AVX512VL/F instruction--VCVTUDQ2PS--or a long sequence of SSE4.1 compatible instructions.

It is still a draft as it depends on some commits in #1759.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 03 2020 at 23:30):

abrown updated PR #1765 from i32x4-to-f32x4 to master:

This converts an i32x4 into an f32x4 with some rounding either by using an AVX512VL/F instruction--VCVTUDQ2PS--or a long sequence of SSE4.1 compatible instructions.

It is still a draft as it depends on some commits in #1759.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 04 2020 at 00:01):

abrown has marked PR #1765 as ready for review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 04 2020 at 00:01):

abrown edited PR #1765 from i32x4-to-f32x4 to master:

This converts an i32x4 into an f32x4 with some rounding either by using an AVX512VL/F instruction--VCVTUDQ2PS--or a long sequence of SSE4.1 compatible instructions.

It is still a draft as it depends on some commits in #1759.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 04 2020 at 00:01):

abrown requested bnjbvr for a review on PR #1765.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 09 2020 at 13:26):

bnjbvr requested bnjbvr and julian-seward1 for a review on PR #1765.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 11 2020 at 17:43):

abrown updated PR #1765 from i32x4-to-f32x4 to master:

This converts an i32x4 into an f32x4 with some rounding either by using an AVX512VL/F instruction--VCVTUDQ2PS--or a long sequence of SSE4.1 compatible instructions.

It is still a draft as it depends on some commits in #1759.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 12 2020 at 15:52):

julian-seward1 submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 12 2020 at 15:52):

julian-seward1 submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 12 2020 at 15:52):

julian-seward1 created PR Review Comment:

What rounding behavior does VCVTUDQ2PS have? Is it: +inf -inf to-zero to-nearest or is it mxcsr dependent? Please mention this in the comment.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 12 2020 at 15:52):

julian-seward1 created PR Review Comment:

Could you write out the sequence of SSE41 insns in a comment? It's hard to infer them from the sequence of lets below.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 12 2020 at 15:52):

julian-seward1 created PR Review Comment:

As per previous review comment, please document the rounding behaviour here.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 12 2020 at 16:42):

abrown updated PR #1765 from i32x4-to-f32x4 to master:

This converts an i32x4 into an f32x4 with some rounding either by using an AVX512VL/F instruction--VCVTUDQ2PS--or a long sequence of SSE4.1 compatible instructions.

It is still a draft as it depends on some commits in #1759.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 12 2020 at 16:48):

abrown submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 12 2020 at 16:48):

abrown created PR Review Comment:

MXCSR by default, overriden by static rounding control in EVEX.L'L; per the manual, sec. 2.6.8, the static rounding control only applies to scalar and 512-bit instructions, so our use of the 128-bit vector length will rely on MXCSR.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 12 2020 at 16:49):

abrown submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 12 2020 at 16:49):

abrown created PR Review Comment:

Documented in this description.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 12 2020 at 18:20):

abrown updated PR #1765 from i32x4-to-f32x4 to master:

This converts an i32x4 into an f32x4 with some rounding either by using an AVX512VL/F instruction--VCVTUDQ2PS--or a long sequence of SSE4.1 compatible instructions.

It is still a draft as it depends on some commits in #1759.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 12 2020 at 22:06):

abrown merged PR #1765.

Last updated: Oct 23 2024 at 20:03 UTC