Wasmtime GitHub notifications bot (May 26 2020 at 03:01): Wasmtime GitHub notifications bot (May 26 2020 at 03:01):abrown opened PR #1754 from interp-recursion to master:
This resolves @bnjbvr's comment in #1223.
Wasmtime GitHub notifications bot (May 26 2020 at 03:02):abrown requested bnjbvr for a review on PR #1754.
Wasmtime GitHub notifications bot (May 26 2020 at 08:02):bnjbvr submitted PR Review.
Wasmtime GitHub notifications bot (May 26 2020 at 08:02):bnjbvr created PR Review Comment:
Should we use a
trace!here to be consistent with the other PR?
Wasmtime GitHub notifications bot (May 26 2020 at 08:02):bnjbvr submitted PR Review.
Wasmtime GitHub notifications bot (May 26 2020 at 08:02):bnjbvr created PR Review Comment:
pre-existing: this comment is lying just a bit, right? It interprets from a given block up to the function's return, if I'm not mistaken.
Wasmtime GitHub notifications bot (May 26 2020 at 15:19):abrown updated PR #1754 from interp-recursion to master:
This resolves @bnjbvr's comment in #1223.
Wasmtime GitHub notifications bot (May 26 2020 at 15:21):abrown updated PR #1754 from interp-recursion to master:
This resolves @bnjbvr's comment in #1223.
Wasmtime GitHub notifications bot (May 26 2020 at 15:23):abrown submitted PR Review.
Wasmtime GitHub notifications bot (May 26 2020 at 15:23):abrown created PR Review Comment:
Good call... changed.
Wasmtime GitHub notifications bot (May 26 2020 at 15:24):abrown submitted PR Review.
Wasmtime GitHub notifications bot (May 26 2020 at 15:24):abrown created PR Review Comment:
Sure, added a commit for that.
Wasmtime GitHub notifications bot (May 26 2020 at 16:45):bnjbvr merged PR #1754.
Last updated: Nov 22 2024 at 16:03 UTC