Stream: git-wasmtime

Topic: wasmtime / PR #1746 cranelift: add i64.[us]{div,rem} libc...

Wasmtime GitHub notifications bot (May 22 2020 at 07:49):

whitequark opened PR #1746 from i64-divrem-libcalls to master:

These libcalls are useful for 32-bit platforms, which do not have native 64-bit div/rem operations. The tests are similar to the existing ones in i64-arith.clif, but for i686.

Wasmtime GitHub notifications bot (May 22 2020 at 08:20):

bjorn3 submitted PR Review.

Wasmtime GitHub notifications bot (May 22 2020 at 08:20):

bjorn3 created PR Review Comment:

Please use the same names as compiler-builtins. For example __udivdi3 for UdivI64:

https://github.com/rust-lang/compiler-builtins/blob/1108d2af9d9df3ae14b06d35a11190aa55097ab8/src/int/udiv.rs#L232

Wasmtime GitHub notifications bot (May 22 2020 at 08:22):

whitequark submitted PR Review.

Wasmtime GitHub notifications bot (May 22 2020 at 08:22):

whitequark created PR Review Comment:

Will do, I wasn't sure which convention cranelift was using here.

Wasmtime GitHub notifications bot (May 22 2020 at 08:28):

bjorn3 submitted PR Review.

Wasmtime GitHub notifications bot (May 22 2020 at 08:28):

bjorn3 created PR Review Comment:

Except for __cranelift_probestack all functions here are defined by system libraries.

Wasmtime GitHub notifications bot (May 22 2020 at 08:31):

whitequark submitted PR Review.

Wasmtime GitHub notifications bot (May 22 2020 at 08:31):

whitequark created PR Review Comment:

What's the implementation in runtime/src/libcalls.rs for, then?

Wasmtime GitHub notifications bot (May 22 2020 at 08:54):

bjorn3 submitted PR Review.

Wasmtime GitHub notifications bot (May 22 2020 at 08:54):

bjorn3 created PR Review Comment:

That one is used for Wasmtime only. This is a default mapping for other users of Cranelift.

Wasmtime GitHub notifications bot (May 22 2020 at 10:55):

whitequark updated PR #1746 from i64-divrem-libcalls to master:

These libcalls are useful for 32-bit platforms, which do not have native 64-bit div/rem operations. The tests are similar to the existing ones in i64-arith.clif, but for i686.

Wasmtime GitHub notifications bot (May 22 2020 at 10:56):

whitequark submitted PR Review.

Wasmtime GitHub notifications bot (May 22 2020 at 10:56):

whitequark created PR Review Comment:

Done

Wasmtime GitHub notifications bot (May 22 2020 at 11:39):

bjorn3 submitted PR Review.

Wasmtime GitHub notifications bot (May 22 2020 at 11:39):

bjorn3 created PR Review Comment:

        ir::LibCall::UdivI64 => "__udivdi3".to_owned(),
        ir::LibCall::SdivI64 => "__divdi3".to_owned(),
        ir::LibCall::UremI64 => "__umoddi3".to_owned(),
        ir::LibCall::SremI64 => "__moddi3".to_owned(),

Wasmtime GitHub notifications bot (May 22 2020 at 11:42):

whitequark updated PR #1746 from i64-divrem-libcalls to master:

These libcalls are useful for 32-bit platforms, which do not have native 64-bit div/rem operations. The tests are similar to the existing ones in i64-arith.clif, but for i686.

Wasmtime GitHub notifications bot (May 22 2020 at 11:42):

whitequark submitted PR Review.

Wasmtime GitHub notifications bot (May 22 2020 at 11:42):

whitequark created PR Review Comment:

Oh sorry, I completely forgot that ceil isn't a builtin and thought the underscores are added elsewhere. Fixed.

Wasmtime GitHub notifications bot (May 22 2020 at 11:47):

bjorn3 submitted PR Review.

Wasmtime GitHub notifications bot (May 22 2020 at 15:50):

fitzgen submitted PR Review.

Wasmtime GitHub notifications bot (May 22 2020 at 15:50):

fitzgen merged PR #1746.

Last updated: Oct 23 2024 at 20:03 UTC