wasmtime / PR #1744 x86: add encoding for bnot.b1 · git-wasmtime

To actually run this test, this needs a ; run after the function. Then it should fail, since the logic of band true, false should be false and the test runner will interpret that as a failed test. Perhaps change v222 to true?

Wasmtime GitHub notifications bot (May 27 2020 at 16:46):

abrown submitted PR Review.

Wasmtime GitHub notifications bot (May 27 2020 at 16:46):

abrown created PR Review Comment:

@abrown Your review doesn't contain any code comments.

@bjorn3, that's because I'm slow...

Wasmtime GitHub notifications bot (May 28 2020 at 00:44):

whitequark updated PR #1744 from x86-encode-bnot.b1 to master:

Fixes #1743.

Wasmtime GitHub notifications bot (May 28 2020 at 00:44):

whitequark submitted PR Review.

Wasmtime GitHub notifications bot (May 28 2020 at 00:44):

whitequark created PR Review Comment:

Done

Wasmtime GitHub notifications bot (May 28 2020 at 09:43):

bjorn3 created PR Review Comment:

function u0:323() -> b1 {
Use the default calling convention to fix test run on Windows.

Wasmtime GitHub notifications bot (May 28 2020 at 09:43):

bjorn3 submitted PR Review.

Wasmtime GitHub notifications bot (May 28 2020 at 09:46):

whitequark submitted PR Review.

Wasmtime GitHub notifications bot (May 28 2020 at 09:46):

whitequark created PR Review Comment:

Ah I missed that, thanks!

Wasmtime GitHub notifications bot (May 28 2020 at 09:47):

whitequark updated PR #1744 from x86-encode-bnot.b1 to master:

Fixes #1743.

Wasmtime GitHub notifications bot (May 28 2020 at 10:34):

bjorn3 submitted PR Review.

Wasmtime GitHub notifications bot (May 28 2020 at 15:43):

abrown submitted PR Review.

Wasmtime GitHub notifications bot (May 28 2020 at 15:43):

abrown merged PR #1744.

Last updated: Oct 23 2024 at 20:03 UTC