Stream: git-wasmtime

Topic: wasmtime / PR #1744 x86: add encoding for bnot.b1


view this post on Zulip Wasmtime GitHub notifications bot (May 21 2020 at 22:09):

whitequark opened PR #1744 from x86-encode-bnot.b1 to master:

Fixes #1743.

view this post on Zulip Wasmtime GitHub notifications bot (May 21 2020 at 22:10):

whitequark updated PR #1744 from x86-encode-bnot.b1 to master:

Fixes #1743.

view this post on Zulip Wasmtime GitHub notifications bot (May 22 2020 at 03:51):

abrown requested abrown for a review on PR #1744.

view this post on Zulip Wasmtime GitHub notifications bot (May 22 2020 at 04:04):

abrown submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (May 22 2020 at 06:29):

bjorn3 submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (May 22 2020 at 06:29):

bjorn3 created PR Review Comment:

Can you make this a binemit test instead? Also a run test may be appropriate.

view this post on Zulip Wasmtime GitHub notifications bot (May 22 2020 at 06:29):

bjorn3 submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (May 22 2020 at 07:58):

whitequark updated PR #1744 from x86-encode-bnot.b1 to master:

Fixes #1743.

view this post on Zulip Wasmtime GitHub notifications bot (May 22 2020 at 08:00):

whitequark updated PR #1744 from x86-encode-bnot.b1 to master:

Fixes #1743.

view this post on Zulip Wasmtime GitHub notifications bot (May 22 2020 at 08:00):

whitequark created PR Review Comment:

Done

view this post on Zulip Wasmtime GitHub notifications bot (May 22 2020 at 08:00):

whitequark submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (May 22 2020 at 08:05):

whitequark updated PR #1744 from x86-encode-bnot.b1 to master:

Fixes #1743.

view this post on Zulip Wasmtime GitHub notifications bot (May 27 2020 at 16:40):

abrown submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (May 27 2020 at 16:45):

abrown submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (May 27 2020 at 16:45):

abrown created PR Review Comment:

To actually run this test, this needs a ; run after the function. Then it should fail, since the logic of band true, false should be false and the test runner will interpret that as a failed test. Perhaps change v222 to true?

view this post on Zulip Wasmtime GitHub notifications bot (May 27 2020 at 16:46):

abrown submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (May 27 2020 at 16:46):

abrown created PR Review Comment:

@abrown Your review doesn't contain any code comments.

@bjorn3, that's because I'm slow...

view this post on Zulip Wasmtime GitHub notifications bot (May 28 2020 at 00:44):

whitequark updated PR #1744 from x86-encode-bnot.b1 to master:

Fixes #1743.

view this post on Zulip Wasmtime GitHub notifications bot (May 28 2020 at 00:44):

whitequark submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (May 28 2020 at 00:44):

whitequark created PR Review Comment:

Done

view this post on Zulip Wasmtime GitHub notifications bot (May 28 2020 at 09:43):

bjorn3 created PR Review Comment:

function u0:323() -> b1 {

Use the default calling convention to fix test run on Windows.

view this post on Zulip Wasmtime GitHub notifications bot (May 28 2020 at 09:43):

bjorn3 submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (May 28 2020 at 09:46):

whitequark submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (May 28 2020 at 09:46):

whitequark created PR Review Comment:

Ah I missed that, thanks!

view this post on Zulip Wasmtime GitHub notifications bot (May 28 2020 at 09:47):

whitequark updated PR #1744 from x86-encode-bnot.b1 to master:

Fixes #1743.

view this post on Zulip Wasmtime GitHub notifications bot (May 28 2020 at 10:34):

bjorn3 submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (May 28 2020 at 15:43):

abrown submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (May 28 2020 at 15:43):

abrown merged PR #1744.


Last updated: Dec 23 2024 at 13:07 UTC