Stream: git-wasmtime

Topic: wasmtime / PR #1741 Merge `vcode` filetest mode into `com...

Wasmtime GitHub notifications bot (May 21 2020 at 19:15):

cfallin opened PR #1741 from filetest-vcode-compile to master:

I hadn't realized before that the filetest backend for test vcode is
doing essentially what compile is doing, but for new (MachInst)
backends: it is just getting a disassembly and running it through
filecheck. There's no reason not to reuse test compile for the AArch64
tests as well.

This was motivated by the desire to have "this IR compiles successfully"
tests work on both x86 and AArch64. It seems this should work fine by
adding multiple target directives when a test case should be
compile-tested on multiple architectures.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (May 21 2020 at 19:15):

cfallin requested sunfishcode for a review on PR #1741.

Wasmtime GitHub notifications bot (May 22 2020 at 04:11):

abrown submitted PR Review.

Wasmtime GitHub notifications bot (May 22 2020 at 04:11):

abrown created PR Review Comment:

Should this be guarded by if isa.get_mach_backend().is_some() ... like below then?

Wasmtime GitHub notifications bot (May 22 2020 at 04:19):

abrown submitted PR Review.

Wasmtime GitHub notifications bot (May 22 2020 at 04:19):

abrown created PR Review Comment:

I hadn't noticed this mach_compile_result before and this comment is irrelevant to this PR, but it does feel like there is probably a re-factoring out there somewhere where the new backend and the old co-exist a little more cleanly (e.g. have the Mach logic in DisplayFunction and TargetIsa instead of a separate top-level field or something along those lines).

Wasmtime GitHub notifications bot (May 22 2020 at 04:20):

abrown submitted PR Review.

Wasmtime GitHub notifications bot (May 23 2020 at 00:29):

cfallin updated PR #1741 from filetest-vcode-compile to master:

I hadn't realized before that the filetest backend for test vcode is
doing essentially what compile is doing, but for new (MachInst)
backends: it is just getting a disassembly and running it through
filecheck. There's no reason not to reuse test compile for the AArch64
tests as well.

This was motivated by the desire to have "this IR compiles successfully"
tests work on both x86 and AArch64. It seems this should work fine by
adding multiple target directives when a test case should be
compile-tested on multiple architectures.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (May 23 2020 at 00:29):

cfallin submitted PR Review.

Wasmtime GitHub notifications bot (May 23 2020 at 00:29):

cfallin created PR Review Comment:

Fixed, thanks!

Wasmtime GitHub notifications bot (May 23 2020 at 00:31):

cfallin submitted PR Review.

Wasmtime GitHub notifications bot (May 23 2020 at 00:31):

cfallin created PR Review Comment:

Yeah, in general I agree; it's a little tricky because the interfaces don't provide quite the same functionality, but I'll think about this a bit more to see if there isn't some way to clean it up.

Wasmtime GitHub notifications bot (May 23 2020 at 01:57):

cfallin merged PR #1741.

Last updated: Oct 23 2024 at 20:03 UTC