Stream: git-wasmtime

Topic: wasmtime / PR #1732 arm64: Use FPU instrctions for Fcopysign

view this post on Zulip Wasmtime GitHub notifications bot (May 20 2020 at 14:49):

jgouly opened PR #1732 from copysign-fpu to master.

view this post on Zulip Wasmtime GitHub notifications bot (May 20 2020 at 15:09):

cfallin submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (May 20 2020 at 15:09):

cfallin submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (May 20 2020 at 15:09):

cfallin created PR Review Comment:

A comment here might be useful, because it's pretty subtle: it seems that 32-bit / 64-bit constants are indicated by bits 5 / 6, and the literal values 32 and 64 just happen to have those bits, so the add works? Also perhaps add a note that (by construction) value is less than bits, so it won't carry?

view this post on Zulip Wasmtime GitHub notifications bot (May 20 2020 at 15:09):

cfallin created PR Review Comment:

Doc comment here (and I suppose on the other arms too) for those less familiar with AArch64: "shift left and insert", maybe briefly note the semantics (Rd |= Rn << imm I think?) too.

view this post on Zulip Wasmtime GitHub notifications bot (May 20 2020 at 15:10):

cfallin edited PR Review Comment.

view this post on Zulip Wasmtime GitHub notifications bot (May 21 2020 at 17:15):

jgouly updated PR #1732 from copysign-fpu to master.

view this post on Zulip Wasmtime GitHub notifications bot (May 23 2020 at 00:25):

cfallin merged PR #1732.

Last updated: Oct 23 2024 at 20:03 UTC