jgouly opened PR #1732 from copysign-fpu
to master
.
cfallin submitted PR Review.
cfallin submitted PR Review.
cfallin created PR Review Comment:
A comment here might be useful, because it's pretty subtle: it seems that 32-bit / 64-bit constants are indicated by bits 5 / 6, and the literal values
32
and64
just happen to have those bits, so the add works? Also perhaps add a note that (by construction)value
is less thanbits
, so it won't carry?
cfallin created PR Review Comment:
Doc comment here (and I suppose on the other arms too) for those less familiar with AArch64: "shift left and insert", maybe briefly note the semantics (
Rd |= Rn << imm
I think?) too.
cfallin edited PR Review Comment.
jgouly updated PR #1732 from copysign-fpu
to master
.
cfallin merged PR #1732.
Last updated: Dec 23 2024 at 12:05 UTC