Stream: git-wasmtime

Topic: wasmtime / PR #1719 Fix Wasm from rust docs

Wasmtime GitHub notifications bot (May 16 2020 at 16:05):

austinabell opened PR #1719 from docsfix to master:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Hello!

I was playing around with this and noticed the docs are a bit broken. Here are my changes:

• Update wasmtime version in docs to 0.16.0
  • Breaking API changes from #1524 were made in the docs, but the old version was kept
• Change second code wat example.
  • The run function does not return anything (I guess another option would be to return some value to keep the function call the same signature as previous but I think this may help some)
• Expose the whole file code for the updated usage on the second example
  • Expanding from the previous example, it is confusing how the code is setup for this, as there is the other changes needed for this to run successfully
  • Open to suggestions or reverting this, as this is more opinionated

Link to docs for reference, if it helps: https://bytecodealliance.github.io/wasmtime/lang-rust.html

Wasmtime GitHub notifications bot (May 16 2020 at 16:15):

austinabell updated PR #1719 from docsfix to master:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Hello!

I was playing around with this and noticed the docs are a bit broken. Here are my changes:

• Update wasmtime version in docs to 0.16.0
  • Breaking API changes from #1524 were made in the docs, but the old version was kept
• Change second code wat example.
  • The run function does not return anything (I guess another option would be to return some value to keep the function call the same signature as previous but I think this may help some)
• Expose the whole file code for the updated usage on the second example
  • Expanding from the previous example, it is confusing how the code is setup for this, as there is the other changes needed for this to run successfully
  • Open to suggestions or reverting this, as this is more opinionated

Link to docs for reference, if it helps: https://bytecodealliance.github.io/wasmtime/lang-rust.html

Wasmtime GitHub notifications bot (May 16 2020 at 16:29):

austinabell updated PR #1719 from docsfix to master:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Hello!

I was playing around with this and noticed the docs are a bit broken. Here are my changes:

• Update wasmtime version in docs to 0.16.0
  • Breaking API changes from #1524 were made in the docs, but the old version was kept
• Change second code wat example.
  • The run function does not return anything (I guess another option would be to return some value to keep the function call the same signature as previous but I think this may help some)
• Expose the whole file code for the updated usage on the second example
  • Expanding from the previous example, it is confusing how the code is setup for this, as there is the other changes needed for this to run successfully
  • Open to suggestions or reverting this, as this is more opinionated

Link to docs for reference, if it helps: https://bytecodealliance.github.io/wasmtime/lang-rust.html

Wasmtime GitHub notifications bot (May 18 2020 at 11:58):

alexcrichton merged PR #1719.

Last updated: Nov 22 2024 at 16:03 UTC