Stream: git-wasmtime

Topic: wasmtime / PR #1699 Reduce arm64 Inst enum size


view this post on Zulip Wasmtime GitHub notifications bot (May 14 2020 at 14:23):

jgouly opened PR #1699 from inst-size to master:

This reduces the size of the Inst enum from 112 bytes to 48 bytes.

Using DHAT on a regex-rs.wasm benchmark, valgrind --tool=dhat clif-util compile --target aarch64

The total number of allocated bytes, drops by around 170 MB.
At t-gmax drops by 3 MB.

Using perf stat clif-util compile --target aarch64, the instructions count dropped by 0.6%. Cache misses dropped by 6%. Cycles dropped by 2.3%.

Suggestions (or help!) for measuring this further are welcomed.

Inspired by nnethercote's changes / articles about reducing enum sizes in rustc.

view this post on Zulip Wasmtime GitHub notifications bot (May 14 2020 at 15:17):

jgouly updated PR #1699 from inst-size to master:

This reduces the size of the Inst enum from 112 bytes to 48 bytes.

Using DHAT on a regex-rs.wasm benchmark, valgrind --tool=dhat clif-util compile --target aarch64

The total number of allocated bytes, drops by around 170 MB.
At t-gmax drops by 3 MB.

Using perf stat clif-util compile --target aarch64, the instructions count dropped by 0.6%. Cache misses dropped by 6%. Cycles dropped by 2.3%.

Suggestions (or help!) for measuring this further are welcomed.

Inspired by nnethercote's changes / articles about reducing enum sizes in rustc.

view this post on Zulip Wasmtime GitHub notifications bot (May 14 2020 at 20:44):

cfallin submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (May 14 2020 at 20:44):

cfallin merged PR #1699.


Last updated: Oct 23 2024 at 20:03 UTC