Stream: git-wasmtime

Topic: wasmtime / PR #1666 Update to regalloc.rs version 0.22.

Wasmtime GitHub notifications bot (May 06 2020 at 15:10):

julian-seward1 opened PR #1666 from resync-with-regalloc to master:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (May 06 2020 at 15:10):

julian-seward1 requested bnjbvr for a review on PR #1666.

Wasmtime GitHub notifications bot (May 06 2020 at 15:19):

bnjbvr submitted PR Review.

Wasmtime GitHub notifications bot (May 06 2020 at 15:19):

bnjbvr created PR Review Comment:

This will break checking with when using the backtracking-checked variant; we should probably use the allocate_registers_with_opts here instead, passing run_checker: true with this variant.

Wasmtime GitHub notifications bot (May 06 2020 at 15:19):

bnjbvr submitted PR Review.

Wasmtime GitHub notifications bot (May 06 2020 at 15:22):

bnjbvr submitted PR Review.

Wasmtime GitHub notifications bot (May 06 2020 at 15:27):

julian-seward1 updated PR #1666 from resync-with-regalloc to master:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (May 06 2020 at 16:02):

julian-seward1 updated PR #1666 from resync-with-regalloc to master:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (May 06 2020 at 16:31):

julian-seward1 updated PR #1666 from resync-with-regalloc to master:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (May 06 2020 at 16:54):

julian-seward1 updated PR #1666 from resync-with-regalloc to master:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (May 06 2020 at 16:55):

bnjbvr submitted PR Review.

Wasmtime GitHub notifications bot (May 06 2020 at 18:16):

julian-seward1 merged PR #1666.

Last updated: Dec 23 2024 at 12:05 UTC