Stream: git-wasmtime

Topic: wasmtime / PR #1662 add the _set suffix to static_memory_...

Wasmtime GitHub notifications bot (May 05 2020 at 19:20):

plicease opened PR #1662 from graham/add-set-suffix to master:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [x] This has been discussed in issue #1501

• [x] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful. The original feature didn't have tests either

• [x] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->
This relates to #1501 and #1513. I think that the _set suffix was missing from these two declarations. I'm calling from Perl using FFI, but my read of the wasmtime.h header file is that they macros create function prototypes with the names in this patch. @alexcrichton wrote the original PR and I am assuming could review.

Wasmtime GitHub notifications bot (May 05 2020 at 19:22):

alexcrichton submitted PR Review.

Wasmtime GitHub notifications bot (May 05 2020 at 19:57):

alexcrichton merged PR #1662.

Last updated: Dec 23 2024 at 13:07 UTC