Stream: git-wasmtime

Topic: wasmtime / PR #1653 Update `Table::grow`'s return to be t...

Wasmtime GitHub notifications bot (May 04 2020 at 20:12):

alexcrichton opened PR #1653 from fix-table-grow to master:

This brings it in line with Memory::grow and the table.grow
instruction which return the size of the table previously, not the size
of the table currently.

Wasmtime GitHub notifications bot (May 05 2020 at 00:29):

peterhuene submitted PR Review.

Wasmtime GitHub notifications bot (May 05 2020 at 00:30):

peterhuene submitted PR Review.

Wasmtime GitHub notifications bot (May 05 2020 at 00:30):

peterhuene created PR Review Comment:

Nit: should we document what it returns in the Some case?

Wasmtime GitHub notifications bot (May 05 2020 at 00:30):

peterhuene edited PR Review Comment.

Wasmtime GitHub notifications bot (May 05 2020 at 17:03):

alexcrichton updated PR #1653 from fix-table-grow to master:

This brings it in line with Memory::grow and the table.grow
instruction which return the size of the table previously, not the size
of the table currently.

Wasmtime GitHub notifications bot (May 05 2020 at 17:03):

alexcrichton merged PR #1653.

Last updated: Dec 23 2024 at 12:05 UTC