Stream: git-wasmtime

Topic: wasmtime / PR #1650 Use `[u8; 16]` instead of `u128` for ...

Wasmtime GitHub notifications bot (May 04 2020 at 18:03):

abrown opened PR #1650 from improve-wast-v128-printing to master:

When troubleshooting WAST test failures, it was difficult to determine what was different between the expected V128 pattern (e.g. [0, 1, 2...]) and the giant integer contained in Val::V128. There are multiple ways to make this more user-friendly, but this change does so by changing the contained type of Val::V128 to the easier to read [u8; 16].

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (May 04 2020 at 18:06):

abrown requested alexcrichton for a review on PR #1650.

Wasmtime GitHub notifications bot (May 11 2020 at 20:45):

abrown closed without merge PR #1650.

Last updated: Nov 22 2024 at 17:03 UTC