Stream: git-wasmtime

Topic: wasmtime / PR #1649 Add x86 legalization for sshr.i64x2

view this post on Zulip Wasmtime GitHub notifications bot (May 04 2020 at 15:29):

abrown opened PR #1649 from add-shift-i64x2 to master:

This adds a legalization for sshr.i64x2 and fixes some issues I found while doing this. It is based on the changes from #1645 since some of the display changes there made these issues easier to troubleshoot.

view this post on Zulip Wasmtime GitHub notifications bot (May 04 2020 at 20:45):

abrown updated PR #1649 from add-shift-i64x2 to master:

This adds a legalization for sshr.i64x2 and fixes some issues I found while doing this. It is based on the changes from #1645 since some of the display changes there made these issues easier to troubleshoot.

view this post on Zulip Wasmtime GitHub notifications bot (May 04 2020 at 20:45):

abrown requested julian-seward1 for a review on PR #1649.

view this post on Zulip Wasmtime GitHub notifications bot (May 05 2020 at 09:41):

julian-seward1 submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (May 05 2020 at 09:41):

julian-seward1 created PR Review Comment:

I am confused by the use of ishl_64x2 at this point. Shouldn't that be ishr_64x2? The actual results shown are consistent with a signed shift right, not a shift left.

view this post on Zulip Wasmtime GitHub notifications bot (May 05 2020 at 09:45):

julian-seward1 created PR Review Comment:

Also I'd be happier if there were a couple more tests here. Could you add a test that 1000-(63)-000 >>signed 63 produces 111-(64)-111 and that 0111-(63)-111 >>signed 63 produces 000-(64)-000 ?

view this post on Zulip Wasmtime GitHub notifications bot (May 05 2020 at 09:45):

julian-seward1 submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (May 05 2020 at 09:47):

julian-seward1 submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (May 05 2020 at 15:24):

abrown submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (May 05 2020 at 15:24):

abrown created PR Review Comment:

Oh, good catch; yeah, that's likely an oversight from copying other tests. I'll fix these and add the additional tests.

view this post on Zulip Wasmtime GitHub notifications bot (May 05 2020 at 18:24):

abrown updated PR #1649 from add-shift-i64x2 to master:

This adds a legalization for sshr.i64x2 and fixes some issues I found while doing this. It is based on the changes from #1645 since some of the display changes there made these issues easier to troubleshoot.

view this post on Zulip Wasmtime GitHub notifications bot (May 05 2020 at 19:01):

abrown merged PR #1649.

Last updated: Dec 23 2024 at 12:05 UTC