Stream: git-wasmtime

Topic: wasmtime / PR #1632 MachInst backend: attach SourceLoc sp...


view this post on Zulip Wasmtime GitHub notifications bot (Apr 29 2020 at 18:03):

cfallin opened PR #1632 from aarch64-fix-srclocs to master:

Previously, the SourceLoc information transferred in VCode only
included PC-spans for non-default SourceLocs. I realized that the
invariant we're supposed to keep here is that every PC is covered; if no
source information, just use SourceLoc::default().

This was spurred by @bjorn3's comment in #1575 (thanks!): link.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Apr 29 2020 at 18:03):

cfallin requested bnjbvr and julian-seward1 for a review on PR #1632.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 29 2020 at 18:03):

cfallin requested bnjbvr and julian-seward1 for a review on PR #1632.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 29 2020 at 19:06):

bjorn3 submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 30 2020 at 08:46):

julian-seward1 submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 30 2020 at 08:46):

julian-seward1 submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 30 2020 at 08:46):

julian-seward1 created PR Review Comment:

Perhaps swap the arguments of the != around, to make this a bit easier to read?

view this post on Zulip Wasmtime GitHub notifications bot (Apr 30 2020 at 22:40):

cfallin updated PR #1632 from aarch64-fix-srclocs to master:

Previously, the SourceLoc information transferred in VCode only
included PC-spans for non-default SourceLocs. I realized that the
invariant we're supposed to keep here is that every PC is covered; if no
source information, just use SourceLoc::default().

This was spurred by @bjorn3's comment in #1575 (thanks!): link.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Apr 30 2020 at 22:41):

cfallin updated PR #1632 from aarch64-fix-srclocs to master:

Previously, the SourceLoc information transferred in VCode only
included PC-spans for non-default SourceLocs. I realized that the
invariant we're supposed to keep here is that every PC is covered; if no
source information, just use SourceLoc::default().

This was spurred by @bjorn3's comment in #1575 (thanks!): link.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Apr 30 2020 at 23:13):

cfallin merged PR #1632.


Last updated: Dec 23 2024 at 13:07 UTC