Wasmtime GitHub notifications bot (Apr 29 2020 at 18:03): Wasmtime GitHub notifications bot (Apr 29 2020 at 18:03):cfallin opened PR #1632 from aarch64-fix-srclocs to master:
Previously, the SourceLoc information transferred in
VCodeonly
included PC-spans for non-default SourceLocs. I realized that the
invariant we're supposed to keep here is that every PC is covered; if no
source information, just useSourceLoc::default().This was spurred by @bjorn3's comment in #1575 (thanks!): link.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Apr 29 2020 at 18:03):cfallin requested bnjbvr and julian-seward1 for a review on PR #1632.
Wasmtime GitHub notifications bot (Apr 29 2020 at 18:03):cfallin requested bnjbvr and julian-seward1 for a review on PR #1632.
Wasmtime GitHub notifications bot (Apr 29 2020 at 19:06):bjorn3 submitted PR Review.
Wasmtime GitHub notifications bot (Apr 30 2020 at 08:46):julian-seward1 submitted PR Review.
Wasmtime GitHub notifications bot (Apr 30 2020 at 08:46):julian-seward1 submitted PR Review.
Wasmtime GitHub notifications bot (Apr 30 2020 at 08:46):julian-seward1 created PR Review Comment:
Perhaps swap the arguments of the
!=around, to make this a bit easier to read?
Wasmtime GitHub notifications bot (Apr 30 2020 at 22:40):cfallin updated PR #1632 from aarch64-fix-srclocs to master:
Previously, the SourceLoc information transferred in
VCodeonly
included PC-spans for non-default SourceLocs. I realized that the
invariant we're supposed to keep here is that every PC is covered; if no
source information, just useSourceLoc::default().This was spurred by @bjorn3's comment in #1575 (thanks!): link.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Apr 30 2020 at 22:41):cfallin updated PR #1632 from aarch64-fix-srclocs to master:
Previously, the SourceLoc information transferred in
VCodeonly
included PC-spans for non-default SourceLocs. I realized that the
invariant we're supposed to keep here is that every PC is covered; if no
source information, just useSourceLoc::default().This was spurred by @bjorn3's comment in #1575 (thanks!): link.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Apr 30 2020 at 23:13):cfallin merged PR #1632.
Last updated: Nov 22 2024 at 17:03 UTC