Stream: git-wasmtime

Topic: wasmtime / PR #1630 moar cranelift tweaks


view this post on Zulip Wasmtime GitHub notifications bot (Apr 29 2020 at 13:42):

bnjbvr opened PR #1630 from cranelift-tweaks to master:

This moves code around to work around a limit on the maximal size of vendored source files in Mozilla central (a single must be < 100,000 bytes), and makes use of the expand group on arm32, because it's now used on every platform and arm32 didn't generated it in meta-code (since it was unused before).

view this post on Zulip Wasmtime GitHub notifications bot (Apr 29 2020 at 13:42):

bnjbvr requested julian-seward1 for a review on PR #1630.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 29 2020 at 15:49):

cfallin submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 29 2020 at 15:49):

cfallin created PR Review Comment:

If the file-size limits allow it, it might be good to move the branch-lowering to lower_inst.rs as well, just to keep all of the opcode-switches together (or if not, perhaps a separate lower_branch.rs).

view this post on Zulip Wasmtime GitHub notifications bot (Apr 29 2020 at 15:49):

cfallin submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 30 2020 at 10:06):

bnjbvr submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 30 2020 at 10:06):

bnjbvr created PR Review Comment:

Yep, up to 80K chars, but still under the 100K limit, done.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 30 2020 at 10:09):

bnjbvr updated PR #1630 from cranelift-tweaks to master:

This moves code around to work around a limit on the maximal size of vendored source files in Mozilla central (a single must be < 100,000 bytes), and makes use of the expand group on arm32, because it's now used on every platform and arm32 didn't generated it in meta-code (since it was unused before).

view this post on Zulip Wasmtime GitHub notifications bot (Apr 30 2020 at 11:50):

bnjbvr merged PR #1630.


Last updated: Dec 23 2024 at 13:07 UTC