Wasmtime GitHub notifications bot (Apr 29 2020 at 13:42): Wasmtime GitHub notifications bot (Apr 29 2020 at 13:42):bnjbvr opened PR #1630 from cranelift-tweaks to master:
This moves code around to work around a limit on the maximal size of vendored source files in Mozilla central (a single must be < 100,000 bytes), and makes use of the
expandgroup on arm32, because it's now used on every platform and arm32 didn't generated it in meta-code (since it was unused before).
Wasmtime GitHub notifications bot (Apr 29 2020 at 13:42):bnjbvr requested julian-seward1 for a review on PR #1630.
Wasmtime GitHub notifications bot (Apr 29 2020 at 15:49):cfallin submitted PR Review.
Wasmtime GitHub notifications bot (Apr 29 2020 at 15:49):cfallin created PR Review Comment:
If the file-size limits allow it, it might be good to move the branch-lowering to
lower_inst.rsas well, just to keep all of the opcode-switches together (or if not, perhaps a separatelower_branch.rs).
Wasmtime GitHub notifications bot (Apr 29 2020 at 15:49):cfallin submitted PR Review.
Wasmtime GitHub notifications bot (Apr 30 2020 at 10:06):bnjbvr submitted PR Review.
Wasmtime GitHub notifications bot (Apr 30 2020 at 10:06):bnjbvr created PR Review Comment:
Yep, up to 80K chars, but still under the 100K limit, done.
Wasmtime GitHub notifications bot (Apr 30 2020 at 10:09):bnjbvr updated PR #1630 from cranelift-tweaks to master:
This moves code around to work around a limit on the maximal size of vendored source files in Mozilla central (a single must be < 100,000 bytes), and makes use of the
expandgroup on arm32, because it's now used on every platform and arm32 didn't generated it in meta-code (since it was unused before).
Wasmtime GitHub notifications bot (Apr 30 2020 at 11:50):bnjbvr merged PR #1630.
Last updated: Nov 22 2024 at 16:03 UTC