Stream: git-wasmtime

Topic: wasmtime / PR #1616 Legalize ireduce.iN.i2N to isplit


view this post on Zulip Wasmtime GitHub notifications bot (Apr 28 2020 at 09:50):

whitequark opened PR #1616 from legalize-ireduce-to-isplit to master:

Although the transformation seems a bit suspicious to me, it seems to work reliably, and this was the only way I could prevent some 64-bit iconcats from crashing codegen for 32-bit targets (#1089).

With this PR, #1615, #1612, pinning VMContext to %esi and a small patch that corrects wasmtime's 64-bit assumptions in two places, I can successfully build reasonably looking 32-bit machine code and run it! Of course, it crashes immediately.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 28 2020 at 09:52):

bjorn3 submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 28 2020 at 10:15):

whitequark updated PR #1616 from legalize-ireduce-to-isplit to master:

Although the transformation seems a bit suspicious to me, it seems to work reliably, and this was the only way I could prevent some 64-bit iconcats from crashing codegen for 32-bit targets (#1089).

With this PR, #1615, #1612, pinning VMContext to %esi and a small patch that corrects wasmtime's 64-bit assumptions in two places, I can successfully build reasonably looking 32-bit machine code and run it! Of course, it crashes immediately.

view this post on Zulip Wasmtime GitHub notifications bot (May 05 2020 at 21:13):

iximeow submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (May 05 2020 at 21:13):

iximeow merged PR #1616.


Last updated: Dec 23 2024 at 12:05 UTC