Stream: git-wasmtime

Topic: wasmtime / PR #1615 Legalize [su]extend.i64 to iconst/ssh...

view this post on Zulip Wasmtime GitHub notifications bot (Apr 28 2020 at 05:29):

whitequark opened PR #1615 from x86_32-legalize-extend to master:

This was already done for [su]extend.i128, and is necessary for codegen for 32-bit x86 (#1089).

view this post on Zulip Wasmtime GitHub notifications bot (Apr 28 2020 at 06:48):

bjorn3 submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 28 2020 at 06:48):

bjorn3 created PR Review Comment:

You can use ty.half_width().

view this post on Zulip Wasmtime GitHub notifications bot (Apr 28 2020 at 06:48):

bjorn3 submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 28 2020 at 06:48):

bjorn3 created PR Review Comment:

You can use ty.bits().

view this post on Zulip Wasmtime GitHub notifications bot (Apr 28 2020 at 10:01):

whitequark submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 28 2020 at 10:01):

whitequark created PR Review Comment:

That (and the other suggestion) doesn't seem to work for me--are these functions really available in codegen/meta?

view this post on Zulip Wasmtime GitHub notifications bot (Apr 28 2020 at 11:40):

bjorn3 submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 28 2020 at 11:40):

bjorn3 created PR Review Comment:

It doesn't seem they are available.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 28 2020 at 11:42):

bjorn3 submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 28 2020 at 20:54):

iximeow created PR Review Comment:

It looks like the enum variants in shared::types are mapped to values indicating their size, so you _could_ do ty_half as usize - 1, but that doesn't hold for enums ir::types. Writing the size here seems fine.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 28 2020 at 20:54):

iximeow submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 28 2020 at 20:55):

iximeow edited PR Review Comment.

view this post on Zulip Wasmtime GitHub notifications bot (May 02 2020 at 04:48):

whitequark updated PR #1615 from x86_32-legalize-extend to master:

This was already done for [su]extend.i128, and is necessary for codegen for 32-bit x86 (#1089).

view this post on Zulip Wasmtime GitHub notifications bot (May 05 2020 at 21:56):

whitequark closed without merge PR #1615.

view this post on Zulip Wasmtime GitHub notifications bot (May 05 2020 at 21:56):

whitequark updated PR #1615 from x86_32-legalize-extend to master:

This was already done for [su]extend.i128, and is necessary for codegen for 32-bit x86 (#1089).

view this post on Zulip Wasmtime GitHub notifications bot (May 05 2020 at 21:57):

whitequark updated PR #1615 from x86_32-legalize-extend to master:

This was already done for [su]extend.i128, and is necessary for codegen for 32-bit x86 (#1089).

view this post on Zulip Wasmtime GitHub notifications bot (May 05 2020 at 21:57):

whitequark reopened PR #1615 from x86_32-legalize-extend to master:

This was already done for [su]extend.i128, and is necessary for codegen for 32-bit x86 (#1089).

view this post on Zulip Wasmtime GitHub notifications bot (May 05 2020 at 21:58):

whitequark updated PR #1615 from x86_32-legalize-extend to master:

This was already done for [su]extend.i128, and is necessary for codegen for 32-bit x86 (#1089).

view this post on Zulip Wasmtime GitHub notifications bot (May 05 2020 at 23:08):

iximeow submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (May 05 2020 at 23:09):

iximeow merged PR #1615.

Last updated: Dec 23 2024 at 12:05 UTC