Stream: git-wasmtime

Topic: wasmtime / PR #1614 Use new regalloc.rs version with dens...


view this post on Zulip Wasmtime GitHub notifications bot (Apr 28 2020 at 03:57):

cfallin opened PR #1614 from aarch64-regalloc-dense-maps to master:

This PR updates Cranelift to use the new version of regalloc.rs
(bytecodealliance/regalloc.rs#55) that provides dense vreg->rreg maps to
the map_reg() function for each instruction, rather than the earlier
hashmap-based approach.

In one test (regex-rs.wasm), this PR results in a 15% reduction in
memory allocations (1245MB -> 1060MB) as measured by DHAT on clif-util wasm runs.

Requires regalloc.rs release and dependency version-bump; CI will be red
until this happens.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Apr 28 2020 at 03:57):

cfallin requested bnjbvr and julian-seward1 for a review on PR #1614.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 28 2020 at 03:57):

cfallin requested bnjbvr and julian-seward1 for a review on PR #1614.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 29 2020 at 14:55):

bnjbvr submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 29 2020 at 17:41):

cfallin updated PR #1614 from aarch64-regalloc-dense-maps to master:

This PR updates Cranelift to use the new version of regalloc.rs
(bytecodealliance/regalloc.rs#55) that provides dense vreg->rreg maps to
the map_reg() function for each instruction, rather than the earlier
hashmap-based approach.

In one test (regex-rs.wasm), this PR results in a 15% reduction in
memory allocations (1245MB -> 1060MB) as measured by DHAT on clif-util wasm runs.

Requires regalloc.rs release and dependency version-bump; CI will be red
until this happens.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Apr 29 2020 at 17:42):

cfallin updated PR #1614 from aarch64-regalloc-dense-maps to master:

This PR updates Cranelift to use the new version of regalloc.rs
(bytecodealliance/regalloc.rs#55) that provides dense vreg->rreg maps to
the map_reg() function for each instruction, rather than the earlier
hashmap-based approach.

In one test (regex-rs.wasm), this PR results in a 15% reduction in
memory allocations (1245MB -> 1060MB) as measured by DHAT on clif-util wasm runs.

Requires regalloc.rs release and dependency version-bump; CI will be red
until this happens.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Apr 29 2020 at 19:29):

cfallin merged PR #1614.


Last updated: Dec 23 2024 at 12:05 UTC