Wasmtime GitHub notifications bot (Apr 28 2020 at 03:57): Wasmtime GitHub notifications bot (Apr 28 2020 at 03:57):cfallin opened PR #1614 from aarch64-regalloc-dense-maps to master:
This PR updates Cranelift to use the new version of regalloc.rs
(bytecodealliance/regalloc.rs#55) that provides dense vreg->rreg maps to
themap_reg()function for each instruction, rather than the earlier
hashmap-based approach.In one test (regex-rs.wasm), this PR results in a 15% reduction in
memory allocations (1245MB -> 1060MB) as measured by DHAT onclif-util wasmruns.Requires regalloc.rs release and dependency version-bump; CI will be red
until this happens.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Apr 28 2020 at 03:57):cfallin requested bnjbvr and julian-seward1 for a review on PR #1614.
Wasmtime GitHub notifications bot (Apr 28 2020 at 03:57):cfallin requested bnjbvr and julian-seward1 for a review on PR #1614.
Wasmtime GitHub notifications bot (Apr 29 2020 at 14:55):bnjbvr submitted PR Review.
Wasmtime GitHub notifications bot (Apr 29 2020 at 17:41):cfallin updated PR #1614 from aarch64-regalloc-dense-maps to master:
This PR updates Cranelift to use the new version of regalloc.rs
(bytecodealliance/regalloc.rs#55) that provides dense vreg->rreg maps to
themap_reg()function for each instruction, rather than the earlier
hashmap-based approach.In one test (regex-rs.wasm), this PR results in a 15% reduction in
memory allocations (1245MB -> 1060MB) as measured by DHAT onclif-util wasmruns.Requires regalloc.rs release and dependency version-bump; CI will be red
until this happens.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Apr 29 2020 at 17:42):cfallin updated PR #1614 from aarch64-regalloc-dense-maps to master:
This PR updates Cranelift to use the new version of regalloc.rs
(bytecodealliance/regalloc.rs#55) that provides dense vreg->rreg maps to
themap_reg()function for each instruction, rather than the earlier
hashmap-based approach.In one test (regex-rs.wasm), this PR results in a 15% reduction in
memory allocations (1245MB -> 1060MB) as measured by DHAT onclif-util wasmruns.Requires regalloc.rs release and dependency version-bump; CI will be red
until this happens.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Apr 29 2020 at 19:29):cfallin merged PR #1614.
Last updated: Nov 22 2024 at 16:03 UTC