Stream: git-wasmtime

Topic: wasmtime / PR #1609 Perform lldb DWARF-5 test too

Wasmtime GitHub notifications bot (Apr 27 2020 at 22:54):

ggreif opened PR #1609 from master to master:

This is basically a copy of test_debug_dwarf5_lldb, only loading a different Wasm file. Please indicate whether it is worth refactoring.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Apr 27 2020 at 23:58):

ggreif updated PR #1609 from master to master:

This is basically a copy of test_debug_dwarf5_lldb, only loading a different Wasm file. Please indicate whether it is worth refactoring.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Apr 28 2020 at 00:14):

ggreif edited PR #1609 from master to master:

This is basically a copy of test_debug_dwarf5_lldb, only loading a different Wasm file. Please indicate whether it is worth refactoring.

Also unlocks test_debug_dwarf5_translate test, which was present, but not selected.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Apr 28 2020 at 13:54):

yurydelendik merged PR #1609.

Last updated: Nov 22 2024 at 16:03 UTC