Stream: git-wasmtime

Topic: wasmtime / PR #1593 Fix a memory leak in the test suite

view this post on Zulip Wasmtime GitHub notifications bot (Apr 24 2020 at 20:35):

alexcrichton opened PR #1593 from fix-test-leak to master:

This test creates a cycle between two Func objects (and indirectly
through their instance) which prevents anything from being collected.
This was found when running tests locally with address sanitizer, and
using a Weak<T> breaks the cycle to allow collecting resources.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 28 2020 at 19:17):

alexcrichton requested fitzgen for a review on PR #1593.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 28 2020 at 21:39):

fitzgen submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 28 2020 at 21:40):

fitzgen merged PR #1593.

Last updated: Dec 23 2024 at 13:07 UTC