Stream: git-wasmtime

Topic: wasmtime / PR #1589 Don't deny warnings on nightly CI

view this post on Zulip Wasmtime GitHub notifications bot (Apr 24 2020 at 15:13):

alexcrichton opened PR #1589 from no-nightly-warnings to master:

Too much churn!

Closes #1588

view this post on Zulip Wasmtime GitHub notifications bot (Apr 24 2020 at 15:15):

bnjbvr submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 24 2020 at 15:15):

bnjbvr submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 24 2020 at 15:15):

bnjbvr created PR Review Comment:

Are there toolchains which names start with nightly but are not nightly? Otherwise we could use toolchain === 'nightly' here.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 24 2020 at 15:16):

alexcrichton submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 24 2020 at 15:16):

alexcrichton created PR Review Comment:

Yeah sometimes we'll switch to nightly-$date temporarily if a regression sneaks into nightly by accident.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 24 2020 at 15:18):

bnjbvr submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 24 2020 at 15:18):

bnjbvr created PR Review Comment:

I see, thanks (resolving).

view this post on Zulip Wasmtime GitHub notifications bot (Apr 24 2020 at 15:55):

alexcrichton merged PR #1589.

Last updated: Nov 22 2024 at 17:03 UTC