Wasmtime GitHub notifications bot (Apr 23 2020 at 11:15): Wasmtime GitHub notifications bot (Apr 23 2020 at 11:15):bnjbvr opened PR #1584 from aarch64-rotations to master:
Given an integer size N, a left rotation of K
places is the same as a right rotation of N - K places. This means we
can use right rotations to implement left rotations too (a left rotation of 32/64 bits operands is now two instructions instead of 5).The Cranelift's rotation semantics are inherited from WebAssembly, which
mean the rotation count is truncated modulo the operand's bit size. Note
the ROR aarch64 instruction has the same semantics, which is nice (and the reason why only left rotations were incorrect).@cfallin PTAL!
Wasmtime GitHub notifications bot (Apr 23 2020 at 11:15):bnjbvr requested cfallin for a review on PR #1584.
Wasmtime GitHub notifications bot (Apr 23 2020 at 18:25):cfallin submitted PR Review.
Wasmtime GitHub notifications bot (Apr 24 2020 at 10:03):bnjbvr updated PR #1584 from aarch64-rotations to master:
Given an integer size N, a left rotation of K
places is the same as a right rotation of N - K places. This means we
can use right rotations to implement left rotations too (a left rotation of 32/64 bits operands is now two instructions instead of 5).The Cranelift's rotation semantics are inherited from WebAssembly, which
mean the rotation count is truncated modulo the operand's bit size. Note
the ROR aarch64 instruction has the same semantics, which is nice (and the reason why only left rotations were incorrect).@cfallin PTAL!
Wasmtime GitHub notifications bot (Apr 24 2020 at 10:37):bnjbvr merged PR #1584.
Last updated: Oct 23 2024 at 20:03 UTC