Stream: git-wasmtime

Topic: wasmtime / PR #1580 Add a MinGW release to our CI


view this post on Zulip Wasmtime GitHub notifications bot (Apr 22 2020 at 21:27):

alexcrichton opened PR #1580 from mingw-ci to master:

This commit extends our CI to produce release artifacts for the
x86_64-pc-windows-gnu target. This was originally motivate by the [go
extension] where it looks like the Go toolchain primarily interoperates
with MinGW, not with MSVC natively.

The support here turned out to be quite trivial, largely just adding the
configuration to make the release. I don't think we should necessarily
commit to this being a primary platform for Wasmtime at this time
though. If the support here regresses in the future for a
difficult-to-fix reason I think it would be fine to back out the
platform at least temporarily.

Note that this does not add a full test suite for the MinGW target, only
a release builder. This release builder does run tests, but not with
full debug assertions enabled.

[go extension]: https://github.com/bytecodealliance/wasmtime-go/issues/3

Closes #1535

view this post on Zulip Wasmtime GitHub notifications bot (Apr 22 2020 at 22:54):

alexcrichton updated PR #1580 from mingw-ci to master:

This commit extends our CI to produce release artifacts for the
x86_64-pc-windows-gnu target. This was originally motivate by the [go
extension] where it looks like the Go toolchain primarily interoperates
with MinGW, not with MSVC natively.

The support here turned out to be quite trivial, largely just adding the
configuration to make the release. I don't think we should necessarily
commit to this being a primary platform for Wasmtime at this time
though. If the support here regresses in the future for a
difficult-to-fix reason I think it would be fine to back out the
platform at least temporarily.

Note that this does not add a full test suite for the MinGW target, only
a release builder. This release builder does run tests, but not with
full debug assertions enabled.

[go extension]: https://github.com/bytecodealliance/wasmtime-go/issues/3

Closes #1535

view this post on Zulip Wasmtime GitHub notifications bot (Apr 24 2020 at 19:42):

alexcrichton requested fitzgen for a review on PR #1580.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 24 2020 at 22:45):

fitzgen submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 24 2020 at 22:45):

fitzgen merged PR #1580.


Last updated: Nov 22 2024 at 16:03 UTC