Stream: git-wasmtime

Topic: wasmtime / PR #1578 aarch64: implement correct float-to-i...


view this post on Zulip Wasmtime GitHub notifications bot (Apr 22 2020 at 17:14):

bnjbvr opened PR #1578 from aarch64-float-to-int-conversions to master:

These are inherited from wasm semantics:

This makes Spidermonkey pass one more test entirely.

@cfallin PTAL!

view this post on Zulip Wasmtime GitHub notifications bot (Apr 22 2020 at 17:14):

bnjbvr requested cfallin for a review on PR #1578.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 22 2020 at 19:09):

cfallin submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 22 2020 at 19:09):

cfallin created PR Review Comment:

Perhaps I'm missing a subtle reason here -- but shouldn't the unsigned-case lower bound be 0.0? Otherwise the >= check will allow e.g. -0.9.

Ah -- does this have to do with the truncation rounding mode? A clarification comment would help if so!

view this post on Zulip Wasmtime GitHub notifications bot (Apr 22 2020 at 19:09):

cfallin submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 23 2020 at 09:15):

bnjbvr submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 23 2020 at 09:15):

bnjbvr created PR Review Comment:

Yes, the "truncate towards zero" was meant to explain it, it might be a bit terse, so I'll reword it.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 23 2020 at 09:44):

bnjbvr updated PR #1578 from aarch64-float-to-int-conversions to master:

These are inherited from wasm semantics:

This makes Spidermonkey pass one more test entirely.

@cfallin PTAL!

view this post on Zulip Wasmtime GitHub notifications bot (Apr 23 2020 at 11:28):

bnjbvr updated PR #1578 from aarch64-float-to-int-conversions to master:

These are inherited from wasm semantics:

This makes Spidermonkey pass one more test entirely.

@cfallin PTAL!

view this post on Zulip Wasmtime GitHub notifications bot (Apr 23 2020 at 12:03):

bnjbvr updated PR #1578 from aarch64-float-to-int-conversions to master:

These are inherited from wasm semantics:

This makes Spidermonkey pass one more test entirely.

@cfallin PTAL!

view this post on Zulip Wasmtime GitHub notifications bot (Apr 24 2020 at 08:53):

bnjbvr updated PR #1578 from aarch64-float-to-int-conversions to master:

These are inherited from wasm semantics:

This makes Spidermonkey pass one more test entirely.

@cfallin PTAL!

view this post on Zulip Wasmtime GitHub notifications bot (Apr 24 2020 at 09:09):

bnjbvr updated PR #1578 from aarch64-float-to-int-conversions to master:

These are inherited from wasm semantics:

This makes Spidermonkey pass one more test entirely.

@cfallin PTAL!

view this post on Zulip Wasmtime GitHub notifications bot (Apr 24 2020 at 09:38):

bjorn3 submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 24 2020 at 09:38):

bjorn3 created PR Review Comment:

        self.block_state.stack = stack;

view this post on Zulip Wasmtime GitHub notifications bot (Apr 24 2020 at 09:38):

bjorn3 submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 24 2020 at 09:38):

bjorn3 created PR Review Comment:

    let session.op_offset_map = op_offset_map;

view this post on Zulip Wasmtime GitHub notifications bot (Apr 24 2020 at 09:51):

bnjbvr merged PR #1578.


Last updated: Dec 23 2024 at 12:05 UTC