Stream: git-wasmtime

Topic: wasmtime / PR #1574 wiggle-generate: paramaterize library...

Wasmtime GitHub notifications bot (Apr 21 2020 at 23:44):

pchickey opened PR #1574 from pch/wiggle_runtime_crate_param to master:

This change makes no functional difference to users who only use the
wiggle crate.

Add a parameter to the Names constructor that determines the module
that runtime components (e.g. GuestPtr, GuestError etc) of wiggle come
from. For wiggle users this is just quote!(wiggle), but other
libraries which consume wiggle-generate may wrap and re-export wiggle
under some other path, and not want their consumers to have to know
about the wiggle dependency, e.g. quote!(my_crate::some_path::wiggle).

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Apr 22 2020 at 00:08):

pchickey requested kubkon for a review on PR #1574.

Wasmtime GitHub notifications bot (Apr 22 2020 at 01:13):

pchickey updated PR #1574 from pch/wiggle_runtime_crate_param to master:

This change makes no functional difference to users who only use the
wiggle crate.

Add a parameter to the Names constructor that determines the module
that runtime components (e.g. GuestPtr, GuestError etc) of wiggle come
from. For wiggle users this is just quote!(wiggle), but other
libraries which consume wiggle-generate may wrap and re-export wiggle
under some other path, and not want their consumers to have to know
about the wiggle dependency, e.g. quote!(my_crate::some_path::wiggle).

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Apr 22 2020 at 01:19):

pchickey edited PR #1574 from pch/wiggle_runtime_crate_param to master:

This change makes no functional difference to users who only use the
wiggle crate.

Add a parameter to the Names constructor that determines the module
that runtime components (e.g. GuestPtr, GuestError etc) of wiggle come
from. For wiggle users this is just quote!(wiggle), but other
libraries which consume wiggle-generate may wrap and re-export wiggle
under some other path, and not want their consumers to have to know
about the wiggle dependency, e.g. quote!(my_crate::some_path::wiggle).

Then, we moved a small amount of logic from the generator into the macro
crate, which makes the generator code more reusable.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Apr 22 2020 at 01:26):

pchickey requested alexcrichton and kubkon for a review on PR #1574.

Wasmtime GitHub notifications bot (Apr 22 2020 at 07:25):

kubkon submitted PR Review.

Wasmtime GitHub notifications bot (Apr 22 2020 at 14:16):

alexcrichton merged PR #1574.

Last updated: Dec 23 2024 at 13:07 UTC