Stream: git-wasmtime

Topic: wasmtime / PR #1563 Automatically label Cranelift new-bac...

view this post on Zulip Wasmtime GitHub notifications bot (Apr 21 2020 at 09:30):

bnjbvr opened PR #1563 from label-cranelift-aarch64 to master.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 21 2020 at 09:30):

bnjbvr requested tschneidereit and fitzgen for a review on PR #1563.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 21 2020 at 09:30):

bnjbvr requested tschneidereit and fitzgen for a review on PR #1563.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 21 2020 at 14:11):

alexcrichton merged PR #1563.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 21 2020 at 14:16):

tschneidereit submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 21 2020 at 14:16):

tschneidereit created PR Review Comment:

Isn't machinst ISA independent? I.e., won't this labeling be wrong as soon as work on supporting other ISAs for the new isel framework picks up?

view this post on Zulip Wasmtime GitHub notifications bot (Apr 21 2020 at 14:16):

tschneidereit submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 21 2020 at 14:19):

bnjbvr submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 21 2020 at 14:19):

bnjbvr created PR Review Comment:

Yes, and we can update the labeling later (it's quick enough to do so). I found it useful to mix both in the meanwhile.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 21 2020 at 14:20):

tschneidereit submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 21 2020 at 14:20):

tschneidereit created PR Review Comment:

Ok, that makes sense :)

Last updated: Nov 22 2024 at 16:03 UTC