Stream: git-wasmtime

Topic: wasmtime / PR #1559 [WIP] SystemV struct arguments

Wasmtime GitHub notifications bot (Apr 20 2020 at 15:22):

bjorn3 opened PR #1559 from abi_struct_args to master:

According to the SystemV abi, struct arguments must be passed at a fixed stack offset. Cranelift didn't have any way to implement this before. This is necessary to compile proc-macros using cg_clif: https://github.com/bjorn3/rustc_codegen_cranelift/issues/905#issuecomment-616173297

Fixes #1108

TODO

• [ ] Don't misuse INVALID, but introduce a proper type.
• [ ] Implement this correctly for WindowsFastcall or give an error.

Wasmtime GitHub notifications bot (Apr 21 2020 at 16:43):

bjorn3 submitted PR Review.

Wasmtime GitHub notifications bot (Apr 21 2020 at 16:44):

bjorn3 created PR Review Comment:

For sarg this must always be done.

Wasmtime GitHub notifications bot (Apr 22 2020 at 15:50):

bjorn3 deleted PR Review Comment.

Wasmtime GitHub notifications bot (Jun 25 2020 at 18:50):

alexcrichton edited PR #1559 from abi_struct_args to main:

According to the SystemV abi, struct arguments must be passed at a fixed stack offset. Cranelift didn't have any way to implement this before. This is necessary to compile proc-macros using cg_clif: https://github.com/bjorn3/rustc_codegen_cranelift/issues/905#issuecomment-616173297

Fixes #1108

TODO

• [ ] Don't misuse INVALID, but introduce a proper type.
• [ ] Implement this correctly for WindowsFastcall or give an error.

Wasmtime GitHub notifications bot (Jun 27 2020 at 14:33):

bjorn3 updated PR #1559 from abi_struct_args to main:

According to the SystemV abi, struct arguments must be passed at a fixed stack offset. Cranelift didn't have any way to implement this before. This is necessary to compile proc-macros using cg_clif: https://github.com/bjorn3/rustc_codegen_cranelift/issues/905#issuecomment-616173297

Fixes #1108

TODO

• [ ] Don't misuse INVALID, but introduce a proper type.
• [ ] Implement this correctly for WindowsFastcall or give an error.

Wasmtime GitHub notifications bot (Jun 27 2020 at 15:24):

bjorn3 updated PR #1559 from abi_struct_args to main:

According to the SystemV abi, struct arguments must be passed at a fixed stack offset. Cranelift didn't have any way to implement this before. This is necessary to compile proc-macros using cg_clif: https://github.com/bjorn3/rustc_codegen_cranelift/issues/905#issuecomment-616173297

Fixes #1108

TODO

• [ ] Don't misuse INVALID, but introduce a proper type.
• [ ] Implement this correctly for WindowsFastcall or give an error.

Wasmtime GitHub notifications bot (Jun 27 2020 at 15:26):

bjorn3 has marked PR #1559 as ready for review.

Wasmtime GitHub notifications bot (Jun 27 2020 at 15:28):

bjorn3 updated PR #1559 from abi_struct_args to main:

According to the SystemV abi, struct arguments must be passed at a fixed stack offset. Cranelift didn't have any way to implement this before. This is necessary to compile proc-macros using cg_clif: https://github.com/bjorn3/rustc_codegen_cranelift/issues/905#issuecomment-616173297

Fixes #1108

TODO

• [ ] Don't misuse INVALID, but introduce a proper type.
• [ ] Implement this correctly for WindowsFastcall or give an error.

Wasmtime GitHub notifications bot (Jun 27 2020 at 17:34):

bjorn3 updated PR #1559 from abi_struct_args to main:

According to the SystemV abi, struct arguments must be passed at a fixed stack offset. Cranelift didn't have any way to implement this before. This is necessary to compile proc-macros using cg_clif: https://github.com/bjorn3/rustc_codegen_cranelift/issues/905#issuecomment-616173297

Fixes #1108

TODO

• [ ] Don't misuse INVALID, but introduce a proper type.
• [ ] Implement this correctly for WindowsFastcall or give an error.

Wasmtime GitHub notifications bot (Jun 27 2020 at 17:43):

bjorn3 updated PR #1559 from abi_struct_args to main:

According to the SystemV abi, struct arguments must be passed at a fixed stack offset. Cranelift didn't have any way to implement this before. This is necessary to compile proc-macros using cg_clif: https://github.com/bjorn3/rustc_codegen_cranelift/issues/905#issuecomment-616173297

Fixes #1108

TODO

• [ ] Don't misuse INVALID, but introduce a proper type.
• [ ] Implement this correctly for WindowsFastcall or give an error.

Wasmtime GitHub notifications bot (Jun 27 2020 at 17:49):

bjorn3 updated PR #1559 from abi_struct_args to main:

According to the SystemV abi, struct arguments must be passed at a fixed stack offset. Cranelift didn't have any way to implement this before. This is necessary to compile proc-macros using cg_clif: https://github.com/bjorn3/rustc_codegen_cranelift/issues/905#issuecomment-616173297

Fixes #1108

TODO

• [ ] Don't misuse INVALID, but introduce a proper type.
• [ ] Implement this correctly for WindowsFastcall or give an error.

Wasmtime GitHub notifications bot (Jun 27 2020 at 19:19):

bjorn3 updated PR #1559 from abi_struct_args to main:

According to the SystemV abi, struct arguments must be passed at a fixed stack offset. Cranelift didn't have any way to implement this before. This is necessary to compile proc-macros using cg_clif: https://github.com/bjorn3/rustc_codegen_cranelift/issues/905#issuecomment-616173297

Fixes #1108

TODO

• [ ] Don't misuse INVALID, but introduce a proper type.
• [ ] Implement this correctly for WindowsFastcall or give an error.

Wasmtime GitHub notifications bot (Jun 27 2020 at 19:25):

bjorn3 updated PR #1559 from abi_struct_args to main:

According to the SystemV abi, struct arguments must be passed at a fixed stack offset. Cranelift didn't have any way to implement this before. This is necessary to compile proc-macros using cg_clif: https://github.com/bjorn3/rustc_codegen_cranelift/issues/905#issuecomment-616173297

Fixes #1108

TODO

• [ ] Don't misuse INVALID, but introduce a proper type.
• [ ] Implement this correctly for WindowsFastcall or give an error.

Wasmtime GitHub notifications bot (Jun 27 2020 at 19:44):

bjorn3 updated PR #1559 from abi_struct_args to main:

According to the SystemV abi, struct arguments must be passed at a fixed stack offset. Cranelift didn't have any way to implement this before. This is necessary to compile proc-macros using cg_clif: https://github.com/bjorn3/rustc_codegen_cranelift/issues/905#issuecomment-616173297

Fixes #1108

TODO

• [ ] Don't misuse INVALID, but introduce a proper type.
• [ ] Implement this correctly for WindowsFastcall or give an error.

Last updated: Nov 22 2024 at 16:03 UTC