Stream: git-wasmtime

Topic: wasmtime / PR #1557 Remove wasi-common's dependency on `num`


view this post on Zulip Wasmtime GitHub notifications bot (Apr 20 2020 at 14:23):

alexcrichton opened PR #1557 from rm-num to master:

This dependency was unfortunately causing rebuilds switching between
cargo test and cargo build since the num crate had different
features activated in testbuild mode. Instead of fixing this I went
ahead and just removed the small dependency on the num crate in the
wasi-common crate, opting for simple local definitions or using the
standard library's endian-switching methods.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 20 2020 at 14:31):

sunfishcode submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 20 2020 at 15:04):

alexcrichton merged PR #1557.


Last updated: Oct 23 2024 at 20:03 UTC