bnjbvr opened PR #1538 from all-ones-unpatched
to master
:
This PR goes on top of #1530, and adds one commit that makes us emit all ones when the user expects it. (It addresses one item in #1519.)
Propagating the flags down to
emit
is a bit noisy again, it should be pretty stable from now on.
bnjbvr requested cfallin for a review on PR #1538.
cfallin submitted PR Review.
cfallin submitted PR Review.
cfallin created PR Review Comment:
Given that #1530 will land first, can't we use the flags held by the
VCode
directly here (i.e.self.flags
)?
bnjbvr updated PR #1538 from all-ones-unpatched
to master
:
This PR goes on top of #1530, and adds one commit that makes us emit all ones when the user expects it. (It addresses one item in #1519.)
Propagating the flags down to
emit
is a bit noisy again, it should be pretty stable from now on.
bnjbvr requested cfallin for a review on PR #1538.
cfallin submitted PR Review.
cfallin merged PR #1538.
Last updated: Dec 23 2024 at 12:05 UTC