Stream: git-wasmtime

Topic: wasmtime / PR #1538 implement emit_all_ones_funcaddrs in ...

Wasmtime GitHub notifications bot (Apr 17 2020 at 17:04):

bnjbvr opened PR #1538 from all-ones-unpatched to master:

This PR goes on top of #1530, and adds one commit that makes us emit all ones when the user expects it. (It addresses one item in #1519.)

Propagating the flags down to emit is a bit noisy again, it should be pretty stable from now on.

Wasmtime GitHub notifications bot (Apr 17 2020 at 17:04):

bnjbvr requested cfallin for a review on PR #1538.

Wasmtime GitHub notifications bot (Apr 17 2020 at 18:55):

cfallin submitted PR Review.

Wasmtime GitHub notifications bot (Apr 17 2020 at 18:55):

cfallin submitted PR Review.

Wasmtime GitHub notifications bot (Apr 17 2020 at 18:55):

cfallin created PR Review Comment:

Given that #1530 will land first, can't we use the flags held by the VCode directly here (i.e. self.flags)?

Wasmtime GitHub notifications bot (Apr 21 2020 at 15:23):

bnjbvr updated PR #1538 from all-ones-unpatched to master:

This PR goes on top of #1530, and adds one commit that makes us emit all ones when the user expects it. (It addresses one item in #1519.)

Propagating the flags down to emit is a bit noisy again, it should be pretty stable from now on.

Wasmtime GitHub notifications bot (Apr 21 2020 at 15:23):

bnjbvr requested cfallin for a review on PR #1538.

Wasmtime GitHub notifications bot (Apr 21 2020 at 16:44):

cfallin submitted PR Review.

Wasmtime GitHub notifications bot (Apr 21 2020 at 16:53):

cfallin merged PR #1538.

Last updated: Nov 22 2024 at 17:03 UTC