Stream: git-wasmtime

Topic: wasmtime / PR #1534 [bugpoint] Remove block params

view this post on Zulip Wasmtime GitHub notifications bot (Apr 17 2020 at 16:49):

teapotd opened PR #1534 from bugpoint-remove-params to master:

This PR adds a mutator for bugpoint that attempts to replace block params with constants. Fixes #1142.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 17 2020 at 17:23):

bjorn3 submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 17 2020 at 17:23):

bjorn3 submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 17 2020 at 17:23):

bjorn3 created PR Review Comment:

Please inline this into the only call site.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 17 2020 at 17:23):

bjorn3 created PR Review Comment:

Maybe we should try to move instructions to the entry block in a new mutator. I opened #1540 for this.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 17 2020 at 17:50):

teapotd updated PR #1534 from bugpoint-remove-params to master:

This PR adds a mutator for bugpoint that attempts to replace block params with constants. Fixes #1142.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 17 2020 at 17:52):

bjorn3 submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 29 2020 at 17:55):

teapotd updated PR #1534 from bugpoint-remove-params to master:

This PR adds a mutator for bugpoint that attempts to replace block params with constants. Fixes #1142.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 29 2020 at 18:00):

abrown submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 29 2020 at 18:00):

abrown created PR Review Comment:

Don't we need a bconst for the boolean types?

view this post on Zulip Wasmtime GitHub notifications bot (Apr 29 2020 at 18:08):

teapotd submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 29 2020 at 18:08):

teapotd created PR Review Comment:

I just moved this function from ReplaceInstWithConst, but yeah, we should add it.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 29 2020 at 18:29):

teapotd updated PR #1534 from bugpoint-remove-params to master:

This PR adds a mutator for bugpoint that attempts to replace block params with constants. Fixes #1142.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 29 2020 at 21:04):

abrown submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 29 2020 at 21:04):

abrown created PR Review Comment:

Ok: https://github.com/bytecodealliance/wasmtime/issues/1633

view this post on Zulip Wasmtime GitHub notifications bot (Apr 29 2020 at 21:04):

abrown submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 29 2020 at 21:05):

abrown merged PR #1534.

Last updated: Nov 22 2024 at 16:03 UTC