Wasmtime GitHub notifications bot (Apr 17 2020 at 12:32): Wasmtime GitHub notifications bot (Apr 17 2020 at 12:32):rylev opened PR #1529 from debug-not-info to master:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->This issue has not been discussed, but I believe it simple enough that a discussion wasn't needed. The
info!log is meant for high level logs that are relevant to every invocation. The logs in this PR are only relevant when debugging so they should use thedebug!logging macro.I'm not sure who should look at this, but perhaps @peterhuene can take a look.
Wasmtime GitHub notifications bot (Apr 17 2020 at 15:14):sunfishcode submitted PR Review.
Wasmtime GitHub notifications bot (Apr 17 2020 at 15:14):sunfishcode submitted PR Review.
Wasmtime GitHub notifications bot (Apr 17 2020 at 15:14):sunfishcode created PR Review Comment:
This error seems is about more than just "here's some stuff you may want if you're debugging". It's more "something unexpected happened which isn't immediately fatal but which may mean the module cache isn't actually caching things".
Wasmtime GitHub notifications bot (Apr 17 2020 at 15:14):sunfishcode created PR Review Comment:
This also seems higher priority than debug. This is "this should be super rare, and even though we have code to handle it, be aware that this super rare thing is happening!"
Wasmtime GitHub notifications bot (Apr 17 2020 at 15:23):rylev submitted PR Review.
Wasmtime GitHub notifications bot (Apr 17 2020 at 15:23):rylev created PR Review Comment:
This sounds like
warnmight be more appropriate then.
Wasmtime GitHub notifications bot (Apr 17 2020 at 15:23):rylev submitted PR Review.
Wasmtime GitHub notifications bot (Apr 17 2020 at 15:23):rylev created PR Review Comment:
this sounds like
warnagain
Wasmtime GitHub notifications bot (Apr 17 2020 at 16:15):sunfishcode submitted PR Review.
Wasmtime GitHub notifications bot (Apr 17 2020 at 16:15):sunfishcode created PR Review Comment:
Makes sense. Would you mind changing this one to
warn?
Wasmtime GitHub notifications bot (Apr 17 2020 at 16:20):sunfishcode submitted PR Review.
Wasmtime GitHub notifications bot (Apr 17 2020 at 16:20):sunfishcode created PR Review Comment:
This message in itself doesn't indicate that something went wrong, just that something we expect to be rare, but still valid, happened. I'll go with your judgement about whether this should be
infoorwarnthough.
Wasmtime GitHub notifications bot (Apr 17 2020 at 18:21):peterhuene submitted PR Review.
Wasmtime GitHub notifications bot (May 06 2020 at 08:32):rylev updated PR #1529 from debug-not-info to master:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->This issue has not been discussed, but I believe it simple enough that a discussion wasn't needed. The
info!log is meant for high level logs that are relevant to every invocation. The logs in this PR are only relevant when debugging so they should use thedebug!logging macro.I'm not sure who should look at this, but perhaps @peterhuene can take a look.
Wasmtime GitHub notifications bot (May 15 2020 at 09:30):rylev requested peterhuene for a review on PR #1529.
Wasmtime GitHub notifications bot (May 15 2020 at 09:30):rylev requested peterhuene and sunfishcode for a review on PR #1529.
Wasmtime GitHub notifications bot (Jun 25 2020 at 18:50):alexcrichton edited PR #1529 from debug-not-info to main:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->This issue has not been discussed, but I believe it simple enough that a discussion wasn't needed. The
info!log is meant for high level logs that are relevant to every invocation. The logs in this PR are only relevant when debugging so they should use thedebug!logging macro.I'm not sure who should look at this, but perhaps @peterhuene can take a look.
Wasmtime GitHub notifications bot (Feb 09 2023 at 08:25):rylev closed without merge PR #1529.
Last updated: Nov 22 2024 at 16:03 UTC