Stream: git-wasmtime

Topic: wasmtime / PR #1527 Add vcode test for floating-point, an...

Wasmtime GitHub notifications bot (Apr 16 2020 at 20:48):

cfallin opened PR #1527 from aarch64-fp-vcode-test to master:

• Added a filetest for the vcode output of lowering every handled FP opcode.

• Fixed two bugs that were discovered while going through the lowerings:

  • Saturating FP->int operators would return u{32,64}::MIN rather than
    0 for a NaN input.

  • fcopysign did not mask off the sign bit of the value whose sign is
    overwritten.

These probably would have been caught by Wasm conformance tests soon
(and the validity of these lowerings will ultimately be tested this way)
but let's get them right by inspection, too!

Addresses a few of probably several more correctness issues needed for #1521; followup to our aarch64 merge in #1494.

Wasmtime GitHub notifications bot (Apr 17 2020 at 11:49):

bnjbvr requested julian-seward1 for a review on PR #1527.

Wasmtime GitHub notifications bot (Apr 19 2020 at 09:03):

bjorn3 submitted PR Review.

Wasmtime GitHub notifications bot (Apr 19 2020 at 09:03):

bjorn3 created PR Review Comment:

            // FMAX Vtmp2, Vtmp2, Vtmp1

Wasmtime GitHub notifications bot (Apr 20 2020 at 18:19):

cfallin updated PR #1527 from aarch64-fp-vcode-test to master:

• Added a filetest for the vcode output of lowering every handled FP opcode.

• Fixed two bugs that were discovered while going through the lowerings:

  • Saturating FP->int operators would return u{32,64}::MIN rather than
    0 for a NaN input.

  • fcopysign did not mask off the sign bit of the value whose sign is
    overwritten.

These probably would have been caught by Wasm conformance tests soon
(and the validity of these lowerings will ultimately be tested this way)
but let's get them right by inspection, too!

Addresses a few of probably several more correctness issues needed for #1521; followup to our aarch64 merge in #1494.

Wasmtime GitHub notifications bot (Apr 21 2020 at 16:43):

cfallin merged PR #1527.

Wasmtime GitHub notifications bot (Apr 21 2020 at 16:44):

julian-seward1 submitted PR Review.

Last updated: Oct 23 2024 at 20:03 UTC