wasmtime / PR #1510 Always check if struct-return paramet... · git-wasmtime

Stream: git-wasmtime

Topic: wasmtime / PR #1510 Always check if struct-return paramet...

Wasmtime GitHub notifications bot (Apr 15 2020 at 10:42):

teapotd opened PR #1510 from abi-i128-fix to master:

Current implementation of legalize_signature for x86 ABI assumes struct-return parameters can be generated only for multi-return functions. This is incorrect: functions can become multi-return after splitting return values in legalize_args - for example functions that return i128. This PR removes this assumption. Fixes #1162.

[x] This has been discussed in issue #1162

[x] This PR contains test cases, if meaningful.

[ ] I'm new to the project, I don't know who could review this.

Wasmtime GitHub notifications bot (Apr 15 2020 at 12:32):

teapotd updated PR #1510 from abi-i128-fix to master:

Current implementation of legalize_signature for x86 ABI assumes struct-return parameters can be generated only for multi-return functions. This is incorrect: functions can become multi-return after splitting return values in legalize_args - for example functions that return i128. This PR removes this assumption. Fixes #1162.

[x] This has been discussed in issue #1162

[x] This PR contains test cases, if meaningful.

[ ] I'm new to the project, I don't know who could review this.

Wasmtime GitHub notifications bot (Apr 15 2020 at 12:58):

teapotd edited PR #1510 from abi-i128-fix to master:

Current implementation of legalize_signature for x86 ABI assumes struct-return parameters can be generated only for multi-return functions. This is incorrect: functions can become multi-return after splitting return values in legalize_args - for example functions that return i128. This PR removes this assumption. Fixes #1162.

[x] This has been discussed in issue #1162

[x] This PR contains test cases, if meaningful.

[x] I'm new to the project, I don't know who could review this.

Wasmtime GitHub notifications bot (Apr 15 2020 at 17:08):

bjorn3 submitted PR Review.

Wasmtime GitHub notifications bot (Apr 15 2020 at 17:08):

bjorn3 created PR Review Comment:

Please also add a system_v test and test i128 arguments.

Wasmtime GitHub notifications bot (Apr 29 2020 at 15:34):

teapotd updated PR #1510 from abi-i128-fix to master:

Current implementation of legalize_signature for x86 ABI assumes struct-return parameters can be generated only for multi-return functions. This is incorrect: functions can become multi-return after splitting return values in legalize_args - for example functions that return i128. This PR removes this assumption. Fixes #1162.

[x] This has been discussed in issue #1162

[x] This PR contains test cases, if meaningful.

[x] I'm new to the project, I don't know who could review this.

Wasmtime GitHub notifications bot (May 07 2020 at 15:04):

teapotd updated PR #1510 from abi-i128-fix to master:

Current implementation of legalize_signature for x86 ABI assumes struct-return parameters can be generated only for multi-return functions. This is incorrect: functions can become multi-return after splitting return values in legalize_args - for example functions that return i128. This PR removes this assumption. Fixes #1162.

[x] This has been discussed in issue #1162

[x] This PR contains test cases, if meaningful.

[x] I'm new to the project, I don't know who could review this.

Wasmtime GitHub notifications bot (May 25 2020 at 18:09):

teapotd updated PR #1510 from abi-i128-fix to master:

Current implementation of legalize_signature for x86 ABI assumes struct-return parameters can be generated only for multi-return functions. This is incorrect: functions can become multi-return after splitting return values in legalize_args - for example functions that return i128. This PR removes this assumption. Fixes #1162.

[x] This has been discussed in issue #1162

[x] This PR contains test cases, if meaningful.

[x] I'm new to the project, I don't know who could review this.

Wasmtime GitHub notifications bot (May 29 2020 at 17:02):

fitzgen submitted PR Review.

Wasmtime GitHub notifications bot (May 29 2020 at 17:02):

fitzgen merged PR #1510.

Last updated: Dec 23 2024 at 12:05 UTC