Stream: git-wasmtime

Topic: wasmtime / PR #15041 wasi-http: Clean up `run_http` test ...

Wasmtime GitHub notifications bot (Oct 28 2026 at 01:20):

adamrk opened PR #15041 from adamrk:abk/cleanup-run_http-test-helper to bytecodealliance:main:

The run_http test helper currently takes a channel and sends the uncollected http request down that channel for the caller to see. But only a few tests actually use that and it can otherwise be difficult because the request body many never actually be read and a guest program can be left hanging if it awaits that.

This change hopefully makes run_http more intuitive by not taking the channel and in general reading the full request body. The new version run_http_get_forwarded_request can be used if the caller needs to see how the request was passed along and the new endpoint p3-test-immediate-response can be used when the test needs a response to be sent without the body being read.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please review the Bytecode Alliance's AI tool usage policy at
https://github.com/bytecodealliance/governance/blob/main/AI_TOOL_POLICY.md

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Oct 28 2026 at 01:20):

adamrk removed the review request for wasmtime-wasi-reviewers from PR #15041.

Wasmtime GitHub notifications bot (Oct 28 2026 at 01:20):

adamrk requested rvolosatovs for a review on PR #15041.

Wasmtime GitHub notifications bot (Oct 28 2026 at 01:20):

adamrk requested wasmtime-wasi-reviewers for a review on PR #15041.

Wasmtime GitHub notifications bot (Oct 28 2026 at 01:20):

adamrk removed the review request for wasmtime-core-reviewers from PR #15041.

Wasmtime GitHub notifications bot (Oct 28 2026 at 01:20):

adamrk requested pchickey for a review on PR #15041.

Wasmtime GitHub notifications bot (Oct 28 2026 at 01:20):

adamrk requested wasmtime-core-reviewers for a review on PR #15041.

Wasmtime GitHub notifications bot (Oct 29 2026 at 17:07):

:memo: rvolosatovs submitted PR review.

Wasmtime GitHub notifications bot (Oct 29 2026 at 17:07):

:speech_balloon: rvolosatovs created PR review comment:

should we check/report errors here? Perhaps we should send a result over request_tx rather than just the collected request?

Wasmtime GitHub notifications bot (Oct 29 2026 at 17:07):

:speech_balloon: rvolosatovs created PR review comment:

could this name be shorter?

Maybe run_http_forwarded or something like that?

Wasmtime GitHub notifications bot (Oct 29 2026 at 19:12):

adamrk updated PR #15041.

Wasmtime GitHub notifications bot (Oct 29 2026 at 19:18):

adamrk updated PR #15041.

Wasmtime GitHub notifications bot (Oct 29 2026 at 19:18):

adamrk requested rvolosatovs for a review on PR #15041.

Wasmtime GitHub notifications bot (Oct 29 2026 at 20:01):

:thumbs_up: rvolosatovs submitted PR review.

Wasmtime GitHub notifications bot (Oct 29 2026 at 20:01):

rvolosatovs added PR #15041 wasi-http: Clean up run_http test helper to the merge queue.

Wasmtime GitHub notifications bot (Oct 30 2026 at 00:03):

:check: rvolosatovs merged PR #15041.

Wasmtime GitHub notifications bot (Oct 30 2026 at 00:03):

rvolosatovs removed PR #15041 wasi-http: Clean up run_http test helper from the merge queue.

Last updated: Oct 31 2026 at 23:03 UTC