Wasmtime GitHub notifications bot (Oct 24 2026 at 12:01): Wasmtime GitHub notifications bot (Oct 24 2026 at 12:01):xia-chao opened PR #14983 from xia-chao:p3-serve-missing-authority to bytecodealliance:main:
#14432 has already fixed the "missing authority/Host ⇒ 400" for p2; this just makes p3 consistent (p3 still passes the request straight to the handler).
Wasmtime GitHub notifications bot (Oct 24 2026 at 12:01):xia-chao removed the review request for wasmtime-wasi-reviewers from PR #14983.
Wasmtime GitHub notifications bot (Oct 24 2026 at 12:01):xia-chao requested wasmtime-wasi-reviewers for a review on PR #14983.
Wasmtime GitHub notifications bot (Oct 24 2026 at 12:01):xia-chao requested rvolosatovs for a review on PR #14983.
Wasmtime GitHub notifications bot (Oct 24 2026 at 12:01):xia-chao removed the review request for wasmtime-core-reviewers from PR #14983.
Wasmtime GitHub notifications bot (Oct 24 2026 at 12:01):xia-chao requested cfallin for a review on PR #14983.
Wasmtime GitHub notifications bot (Oct 24 2026 at 12:01):xia-chao requested wasmtime-core-reviewers for a review on PR #14983.
Wasmtime GitHub notifications bot (Oct 24 2026 at 12:43):xia-chao updated PR #14983.
Wasmtime GitHub notifications bot (Oct 26 2026 at 18:44)::repeat: pchickey submitted PR review.
Wasmtime GitHub notifications bot (Oct 26 2026 at 18:44)::speech_balloon: pchickey created PR review comment:
Reading in a timeout loop is the wrong approach - we want a timeout for the total read, which should use AsyncReadExt::read_to_end, not this loop that appends to the buffer (and uses a fragile heuristic for ending the response)
Wasmtime GitHub notifications bot (Oct 27 2026 at 09:45):xia-chao updated PR #14983.
Wasmtime GitHub notifications bot (Oct 27 2026 at 09:47)::memo: xia-chao submitted PR review.
Wasmtime GitHub notifications bot (Oct 27 2026 at 09:47)::speech_balloon: xia-chao created PR review comment:
you didn't consider that read to end waits for eof, and a keep alive 400 never closes the connection, so it just times out that's why the request sends connection: close.
Wasmtime GitHub notifications bot (Oct 27 2026 at 19:45)::thumbs_up: pchickey submitted PR review.
Wasmtime GitHub notifications bot (Oct 27 2026 at 19:48)::repeat: pchickey submitted PR review:
This is a conflict with https://github.com/bytecodealliance/wasmtime/pull/14988, I lost track with all of the PRs flying around. Wasnt the idea that this PR got closed in favor of that one?
Wasmtime GitHub notifications bot (Oct 28 2026 at 10:53)::cross_mark: xia-chao closed without merge PR #14983.
Last updated: Oct 31 2026 at 23:03 UTC