Stream: git-wasmtime

Topic: wasmtime / PR #14968 Stop filtering from ending the entir...

view this post on Zulip Wasmtime GitHub notifications bot (Oct 23 2026 at 18:03):

V0ldek opened PR #14968 from V0ldek:patch-1 to bytecodealliance:main:

The filter for GC keywords was ending the entire test run in /tests/wast.rs. It's a one line bug where a return should be continue. It looks to be an inadvertent regression from #14245 where a closure was inlined into main and the return now concerns the entire suite and not just the single trial.

To verify, I ran the command that is used in the CI run for GC Zeal where these filters are used and confirmed it returns zero trials. With this change it returns 300.

RUSTFLAGS="--cfg gc_zeal" WASMTIME_TEST_GC_KEYWORDS="gc drc any eq struct array i31 extern exn ref rec"  cargo test --test wast -- --list

Linked: #general > Spurious return in tests/wast.rs

view this post on Zulip Wasmtime GitHub notifications bot (Oct 23 2026 at 18:03):

V0ldek requested dicej for a review on PR #14968.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 23 2026 at 18:03):

V0ldek removed the review request for wasmtime-core-reviewers from PR #14968.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 23 2026 at 18:03):

V0ldek requested wasmtime-core-reviewers for a review on PR #14968.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 23 2026 at 19:04):

:thumbs_up: alexcrichton submitted PR review:

Oops, good catch!

view this post on Zulip Wasmtime GitHub notifications bot (Oct 23 2026 at 19:04):

alexcrichton added PR #14968 Stop filtering from ending the entire wast suite. to the merge queue

view this post on Zulip Wasmtime GitHub notifications bot (Oct 24 2026 at 02:52):

:check: alexcrichton merged PR #14968.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 24 2026 at 02:52):

alexcrichton removed PR #14968 Stop filtering from ending the entire wast suite. from the merge queue

Last updated: Oct 31 2026 at 23:03 UTC