Wasmtime GitHub notifications bot (Oct 23 2026 at 17:24): Wasmtime GitHub notifications bot (Oct 23 2026 at 17:24):xia-chao opened PR #14966 from xia-chao:wasi-write-permit-4streams to bytecodealliance:main:
The stdio, sink, file and C API output streams did not enforce the check-write permit: writes larger than the reported permit were accepted instead of trapping. Make these four streams trap when a write exceeds the permit, as wasi:io requires.
Wasmtime GitHub notifications bot (Oct 23 2026 at 17:24):xia-chao removed the review request for wasmtime-wasi-reviewers from PR #14966.
Wasmtime GitHub notifications bot (Oct 23 2026 at 17:24):xia-chao requested wasmtime-wasi-reviewers for a review on PR #14966.
Wasmtime GitHub notifications bot (Oct 23 2026 at 17:24):xia-chao requested rvolosatovs for a review on PR #14966.
Wasmtime GitHub notifications bot (Oct 23 2026 at 17:24):xia-chao removed the review request for wasmtime-core-reviewers from PR #14966.
Wasmtime GitHub notifications bot (Oct 23 2026 at 17:24):xia-chao requested dicej for a review on PR #14966.
Wasmtime GitHub notifications bot (Oct 23 2026 at 17:24):xia-chao requested wasmtime-core-reviewers for a review on PR #14966.
Wasmtime GitHub notifications bot (Oct 23 2026 at 19:44):github-actions[bot] added the label wasi on PR #14966.
Wasmtime GitHub notifications bot (Oct 23 2026 at 19:44):github-actions[bot] added the label wasmtime:c-api on PR #14966.
Wasmtime GitHub notifications bot (Oct 23 2026 at 20:09)::repeat: pchickey submitted PR review.
Wasmtime GitHub notifications bot (Oct 23 2026 at 20:09)::speech_balloon: pchickey created PR review comment:
I don't think that it is worthwhile for us to track whether check_write has issued the permit, we just need to trap when write exceeds the permitted size, which it already does. So, all of these changes to the cli streams should be thrown away - they already obey the spec from my reading as well as what we enforce in other streams.
Wasmtime GitHub notifications bot (Oct 23 2026 at 20:09)::speech_balloon: pchickey created PR review comment:
this const should be hoisted out to the parent scope, and used in the check_write method as well
Wasmtime GitHub notifications bot (Oct 23 2026 at 20:10):pchickey commented on PR #14966:
This PR is borderline on my radar of needing more careful human review before submission - the changes to c-api and pipe are fundamentally completely different to those proposed in the changes to the stdout/stderr streams, and it would have been nice if you had caught that before submitting.
Wasmtime GitHub notifications bot (Oct 24 2026 at 08:07):xia-chao updated PR #14966.
Wasmtime GitHub notifications bot (Oct 24 2026 at 08:07):xia-chao edited PR #14966:
Dropped the cli tracking. The c-api, sink and file streams now trap when a write exceeds the check-write permit, with one shared budget.
Wasmtime GitHub notifications bot (Oct 24 2026 at 08:15):xia-chao commented on PR #14966:
Noted.
Wasmtime GitHub notifications bot (Oct 26 2026 at 19:26)::thumbs_up: pchickey submitted PR review.
Wasmtime GitHub notifications bot (Oct 26 2026 at 19:26):pchickey added PR #14966 wasi:io: enforce the check-write permit in the remaining output streams to the merge queue.
Wasmtime GitHub notifications bot (Oct 26 2026 at 20:08):github-merge-queue[bot] removed PR #14966 wasi:io: enforce the check-write permit in the remaining output streams from the merge queue.
Wasmtime GitHub notifications bot (Oct 26 2026 at 21:06):pchickey commented on PR #14966:
CI should be fixed by #14998
Wasmtime GitHub notifications bot (Oct 26 2026 at 21:07):pchickey added PR #14966 wasi:io: enforce the check-write permit in the remaining output streams to the merge queue.
Wasmtime GitHub notifications bot (Oct 26 2026 at 21:35):pchickey removed PR #14966 wasi:io: enforce the check-write permit in the remaining output streams from the merge queue.
Wasmtime GitHub notifications bot (Oct 26 2026 at 21:35)::check: pchickey merged PR #14966.
Last updated: Oct 31 2026 at 23:03 UTC