fitzgen requested dicej for a review on PR #14940.
fitzgen requested wasmtime-core-reviewers for a review on PR #14940.
fitzgen opened PR #14940 from fitzgen:inline-libcall-impls-into-raw-libcall-wrappers to bytecodealliance:main:
Otherwise, changing CGU slicing can change whether these do or don't get inlined in practice, which makes for regressions on host-heavy benchmarks (e.g. benchmarks that spend a bunch of time in GC).
Fixes https://github.com/bytecodealliance/are-we-fast-yet/issues/8
See also https://github.com/bytecodealliance/sightglass/pull/348
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease review the Bytecode Alliance's AI tool usage policy at
https://github.com/bytecodealliance/governance/blob/main/AI_TOOL_POLICY.mdPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
fitzgen removed the review request for wasmtime-core-reviewers from PR #14940.
:thumbs_up: alexcrichton submitted PR review.
fitzgen added PR #14940 Inline a few libcall impls into their raw wrappers regardless of CGU slicing to the merge queue.
:check: fitzgen merged PR #14940.
fitzgen removed PR #14940 Inline a few libcall impls into their raw wrappers regardless of CGU slicing from the merge queue.
Last updated: Oct 31 2026 at 23:03 UTC