Stream: git-wasmtime

Topic: wasmtime / PR #14920 [DO NOT REVIEW] Support named import...

Wasmtime GitHub notifications bot (Oct 21 2026 at 19:19):

jrandolf opened PR #14920 from jrandolf:wasi-tls-named-imports to bytecodealliance:main:

Components importing wasi:tls interfaces under a label couldn't be linked with wasmtime-wasi-tls. This adds add_named_to_linker to both p2 and p3, following the named-import support in wasmtime-wasi (#14275).

Most of the diff is in p3: send, receive and connect use Access/Accessor, whose getters can't close over a NamedId. So their bodies move into functions that are generic over the getter, and the named and unnamed implementations share them.

Part of #14858

<details>
<summary>LLM summary of the changes</summary>

API

• WasiTlsNamedView maps a NamedId to the WasiTlsCtxView to use.
• p2::Interface has TlsTypes, and p3::Interface has TlsClient and TlsTypes.
• p2::add_named_to_linker and p3::add_named_to_linker add every labelled import of those interfaces that the component has, asking lookup for each one's id.

Implementation

• The p2 and p3 bindings get named_imports. Each named method looks up the context for the id and calls the existing implementation.
• In p3, the Access/Accessor getters are plain function pointers, so they can't capture a NamedId. The bodies of send, receive and connect move into free functions that are generic over the getter. They're unchanged except that store.get() becomes getter(store.data_mut()). The unnamed implementations pass store.getter(), and the named ones pass a closure that also selects the context for the id.
• ResultProducer stores a generic getter instead of a function pointer, so it works with both.

Interaction with #14873

#14873 changes the signature of the add_named_to_linker lookup. Whichever of the two lands second needs to port these functions, which is mechanical.

Tests

• p2_tls_named_imports and p3_tls_named_imports run new guest programs with two labelled imports. Each label's provider fails every handshake with its own name, which shows which context a call used.
• They need no network, and run once instead of once per TLS provider.

</details>

Wasmtime GitHub notifications bot (Oct 21 2026 at 19:28):

jrandolf commented on PR #14920:

Closing: nobody needs labelled wasi:tls imports yet, and wasi:tls isn't part of a WASI release. Happy to revisit if someone asks.

Wasmtime GitHub notifications bot (Oct 21 2026 at 19:28):

:cross_mark: jrandolf closed without merge PR #14920.

Last updated: Oct 31 2026 at 23:03 UTC