Stream: git-wasmtime

Topic: wasmtime / PR #1492 wasmtime-c-api: Don't create slices w...

view this post on Zulip Wasmtime GitHub notifications bot (Apr 09 2020 at 19:32):

alexcrichton opened PR #1492 from sound-c-api-ptrs to master:

It's a common idiom to pass in NULL for slices of zero-length in the C
API, but it's not safe to create a Rust &[T] slice with this NULL
pointer. Special-case this in the as_slice() method of incoming
vectors to return an empty slice so we don't violate Rust's invariants.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 09 2020 at 19:48):

yurydelendik submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 09 2020 at 19:51):

sunfishcode submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 09 2020 at 20:33):

alexcrichton merged PR #1492.

Last updated: Oct 23 2024 at 20:03 UTC