Wasmtime GitHub notifications bot (Oct 21 2026 at 18:46): Wasmtime GitHub notifications bot (Oct 21 2026 at 18:46):alexcrichton opened PR #14915 from alexcrichton:adjust-scheme to bytecodealliance:main:
This commit is a minor adjustment to #14898 to avoid using the scheme of the request target and instead unconditionally use "http" as the scheme of the connection itself. This mirrors what wasip2 does and means that a request can't accidentally be mistaken as https, for example, when it was actually sent over http.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease review the Bytecode Alliance's AI tool usage policy at
https://github.com/bytecodealliance/governance/blob/main/AI_TOOL_POLICY.mdPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Oct 21 2026 at 18:46):alexcrichton removed the review request for wasmtime-wasi-reviewers from PR #14915.
Wasmtime GitHub notifications bot (Oct 21 2026 at 18:46):alexcrichton requested wasmtime-wasi-reviewers for a review on PR #14915.
Wasmtime GitHub notifications bot (Oct 21 2026 at 18:46):alexcrichton requested rvolosatovs for a review on PR #14915.
Wasmtime GitHub notifications bot (Oct 21 2026 at 18:46):alexcrichton removed the review request for wasmtime-core-reviewers from PR #14915.
Wasmtime GitHub notifications bot (Oct 21 2026 at 18:46):alexcrichton requested dicej for a review on PR #14915.
Wasmtime GitHub notifications bot (Oct 21 2026 at 18:46):alexcrichton requested wasmtime-core-reviewers for a review on PR #14915.
Wasmtime GitHub notifications bot (Oct 21 2026 at 21:03)::thumbs_up: dicej submitted PR review.
Wasmtime GitHub notifications bot (Oct 21 2026 at 21:08):alexcrichton added PR #14915 Use the scheme of the connect, not the request target to the merge queue.
Wasmtime GitHub notifications bot (Oct 21 2026 at 21:55):github-merge-queue[bot] removed PR #14915 Use the scheme of the connect, not the request target from the merge queue.
Wasmtime GitHub notifications bot (Oct 21 2026 at 22:10)::thumbs_up: rvolosatovs submitted PR review:
Does this mean
wasmtime-wasi-httpwould only ever set scheme to HTTPS if it itself handled TLS termination?
Wasmtime GitHub notifications bot (Oct 21 2026 at 22:12):rvolosatovs added PR #14915 Use the scheme of the connect, not the request target to the merge queue.
Wasmtime GitHub notifications bot (Oct 21 2026 at 22:22):alexcrichton commented on PR #14915:
I suspect this probably means that the scheme should be an embedder-provided input since there's basically no way to infer it just from a request object itself
Wasmtime GitHub notifications bot (Oct 21 2026 at 22:35)::check: rvolosatovs merged PR #14915.
Wasmtime GitHub notifications bot (Oct 21 2026 at 22:35):rvolosatovs removed PR #14915 Use the scheme of the connect, not the request target from the merge queue.
Last updated: Oct 31 2026 at 23:03 UTC