alexcrichton opened PR #1491 from optimize-func-wrap
to master
:
This commit optimizes the codegen of
Func::wrap
such that if you do
something likeFunc::wrap(&store, || {})
then the shim generated
contains zero code (as expected). In general this means that the extra
tidbits generated by wasmtime are all eligible to be entirely optimized
away so long as you don't actually rely on something.
alexcrichton requested fitzgen for a review on PR #1491.
fitzgen submitted PR Review.
fitzgen submitted PR Review.
fitzgen created PR Review Comment:
Seems a little simpler/more concise as
debug_assert!(state.is::<(F, Store)>()); let (func, store) = &*(state as *const _ as *const (F, Store));
alexcrichton updated PR #1491 from optimize-func-wrap
to master
:
This commit optimizes the codegen of
Func::wrap
such that if you do
something likeFunc::wrap(&store, || {})
then the shim generated
contains zero code (as expected). In general this means that the extra
tidbits generated by wasmtime are all eligible to be entirely optimized
away so long as you don't actually rely on something.
alexcrichton merged PR #1491.
Last updated: Dec 23 2024 at 12:05 UTC