Stream: git-wasmtime

Topic: wasmtime / PR #14898 wasi-http: fill in scheme and author...


view this post on Zulip Wasmtime GitHub notifications bot (Oct 21 2026 at 12:13):

xia-chao opened PR #14898 from xia-chao:feat/serve-p3-authority to bytecodealliance:main:

p3 doesn't set scheme or authority on requests, so the guest can't see the host.

also no Host header gets a 200, not a 400.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 21 2026 at 12:13):

xia-chao removed the review request for wasmtime-wasi-reviewers from PR #14898.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 21 2026 at 12:13):

xia-chao requested rvolosatovs for a review on PR #14898.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 21 2026 at 12:13):

xia-chao requested wasmtime-wasi-reviewers for a review on PR #14898.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 21 2026 at 12:13):

xia-chao removed the review request for wasmtime-core-reviewers from PR #14898.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 21 2026 at 12:13):

xia-chao requested pchickey for a review on PR #14898.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 21 2026 at 12:13):

xia-chao requested wasmtime-core-reviewers for a review on PR #14898.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 21 2026 at 12:47):

xia-chao updated PR #14898.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 21 2026 at 12:50):

xia-chao edited PR #14898:

p3 requests don't get the scheme or authority, so the guest can't see the host. p2 already does this, so I added it here.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 21 2026 at 16:55):

:thumbs_up: rvolosatovs submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 21 2026 at 16:55):

:speech_balloon: rvolosatovs created PR review comment:

could we avoid the clones here, and instead move values out of parts?
We'd need to call https://docs.rs/http/latest/http/uri/struct.Uri.html#method.into_parts on the URI

view this post on Zulip Wasmtime GitHub notifications bot (Oct 21 2026 at 17:38):

xia-chao updated PR #14898.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 21 2026 at 17:39):

:memo: xia-chao submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 21 2026 at 17:39):

:speech_balloon: xia-chao created PR review comment:

Thank you! I will pay attention to this issue next time!

view this post on Zulip Wasmtime GitHub notifications bot (Oct 21 2026 at 17:50):

rvolosatovs added PR #14898 wasi-http: fill in scheme and authority for p3 serve requests to the merge queue.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 21 2026 at 18:33):

:check: rvolosatovs merged PR #14898.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 21 2026 at 18:33):

rvolosatovs removed PR #14898 wasi-http: fill in scheme and authority for p3 serve requests from the merge queue.


Last updated: Oct 31 2026 at 23:03 UTC