Wasmtime GitHub notifications bot (Oct 20 2026 at 14:29): Wasmtime GitHub notifications bot (Oct 20 2026 at 14:29):xia-chao opened PR #14886 from xia-chao:feat/p3-between-bytes-timeout to bytecodealliance:main:
this is the p3 bit i left out of #14602, between-bytes-timeout never got a test there.
Wasmtime GitHub notifications bot (Oct 20 2026 at 14:29):xia-chao removed the review request for wasmtime-wasi-reviewers from PR #14886.
Wasmtime GitHub notifications bot (Oct 20 2026 at 14:29):xia-chao requested wasmtime-wasi-reviewers for a review on PR #14886.
Wasmtime GitHub notifications bot (Oct 20 2026 at 14:29):xia-chao requested rvolosatovs for a review on PR #14886.
Wasmtime GitHub notifications bot (Oct 20 2026 at 14:29):xia-chao removed the review request for wasmtime-core-reviewers from PR #14886.
Wasmtime GitHub notifications bot (Oct 20 2026 at 14:29):xia-chao requested dicej for a review on PR #14886.
Wasmtime GitHub notifications bot (Oct 20 2026 at 14:29):xia-chao requested wasmtime-core-reviewers for a review on PR #14886.
Wasmtime GitHub notifications bot (Oct 20 2026 at 16:27)::thumbs_up: alexcrichton submitted PR review:
Thanks!
Wasmtime GitHub notifications bot (Oct 20 2026 at 16:27)::speech_balloon: alexcrichton created PR review comment:
Could this duration be a bit smaller? 500ms is an awful long time for a test to be stalled doing nothing in general
Wasmtime GitHub notifications bot (Oct 20 2026 at 16:43):xia-chao updated PR #14886.
Wasmtime GitHub notifications bot (Oct 20 2026 at 16:47)::memo: xia-chao submitted PR review.
Wasmtime GitHub notifications bot (Oct 20 2026 at 16:47)::speech_balloon: xia-chao created PR review comment:
I changed 500ms to 100ms, I don't recommend reducing it.
Wasmtime GitHub notifications bot (Oct 20 2026 at 20:08)::memo: alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Oct 20 2026 at 20:08)::speech_balloon: alexcrichton created PR review comment:
I don't recommend reducing it.
Could you elaborate as to why? I've tried to use 10-50ms for this historically, ideally 10-ish. Why would this want a minimum of 100?
Wasmtime GitHub notifications bot (Oct 21 2026 at 10:59)::memo: xia-chao submitted PR review.
Wasmtime GitHub notifications bot (Oct 21 2026 at 10:59)::speech_balloon: xia-chao created PR review comment:
no real measurement. just worried 10 ms is tight on a loaded ci box, so i kept 100 ms. probably overkill, but flaky tests are worse.
Wasmtime GitHub notifications bot (Oct 21 2026 at 14:06)::memo: alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Oct 21 2026 at 14:06)::speech_balloon: alexcrichton created PR review comment:
But this is testing that a timeout actually occurs right? With the server sleeping for 5+ seconds I'd expect that a short timeout of ~10ms would always fire here
Wasmtime GitHub notifications bot (Oct 21 2026 at 15:13)::speech_balloon: xia-chao created PR review comment:
hmm both fire, yeah. my worry was the first chunk not arriving yet on a slow box, then it still passes without really testing the second chunk. Or 50ms, that's enough margin.
Wasmtime GitHub notifications bot (Oct 21 2026 at 15:21)::memo: xia-chao submitted PR review.
Wasmtime GitHub notifications bot (Oct 21 2026 at 16:07):alexcrichton added PR #14886 wasi-http: test between-bytes-timeout on p3 to the merge queue.
Wasmtime GitHub notifications bot (Oct 21 2026 at 16:11)::thumbs_up: alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Oct 21 2026 at 16:33)::check: alexcrichton merged PR #14886.
Wasmtime GitHub notifications bot (Oct 21 2026 at 16:41):alexcrichton removed PR #14886 wasi-http: test between-bytes-timeout on p3 from the merge queue.
Last updated: Oct 31 2026 at 23:03 UTC