Stream: git-wasmtime

Topic: wasmtime / PR #14882 fix(MachBufferFinalized): add unwind...

view this post on Zulip Wasmtime GitHub notifications bot (Oct 20 2026 at 08:01):

marxin opened PR #14882 from marxin:add-removed-unwind_info-accessor to bytecodealliance:main:

Since 817c58787f432bcdbbb87679011f72c5bc80dbda, the unwind_info cannot be accessed and so I'm adding an accessor.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 20 2026 at 08:01):

marxin removed the review request for wasmtime-compiler-reviewers from PR #14882.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 20 2026 at 08:01):

marxin requested cfallin for a review on PR #14882.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 20 2026 at 08:01):

marxin requested wasmtime-compiler-reviewers for a review on PR #14882.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 20 2026 at 08:02):

marxin edited PR #14882:

Since 817c58787f432bcdbbb87679011f72c5bc80dbda, the unwind_info cannot be accessed and so I'm adding an accessor.

If possible, consider backporting the change to release-50.0.0 branch.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 20 2026 at 08:08):

bjorn3 commented on PR #14882:

The emit_unwind_info method on TargetIsa should still be usable.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 20 2026 at 08:18):

marxin commented on PR #14882:

The emit_unwind_info method on TargetIsa should still be usable.

If I'm not mistaken that will provide unwind info in the systemv form (CallFrameInstruction), but I would like to get to the original &[(CodeOffset, UnwindInst)] type.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 20 2026 at 10:47):

github-actions[bot] added the label cranelift on PR #14882.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 20 2026 at 10:47):

github-actions[bot] added the label cranelift:area:machinst on PR #14882.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 22 2026 at 07:18):

marxin commented on PR #14882:

@cfallin can you please take a look - I feel the intention of 817c58787f432bcdbbb87679011f72c5bc80dbda was more a refactoring and I would like to not loose the API endpoint we depend on. Thank you.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 22 2026 at 15:57):

cfallin commented on PR #14882:

@marxin I'm traveling for work meetings this week and haven't had a chance to review -- will try to do so when I get a chance either in a sliver of time this week, or when I am fully back next week. Thanks for understanding.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 23 2026 at 11:22):

marxin commented on PR #14882:

@marxin I'm traveling for work meetings this week and haven't had a chance to review -- will try to do so when I get a chance either in a sliver of time this week, or when I am fully back next week. Thanks for understanding.

Thanks for letting me know - no need for a rush, we have a plenty of time before the next Wasmtime release.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 23 2026 at 18:25):

:thumbs_up: cfallin submitted PR review:

Thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Oct 23 2026 at 18:25):

cfallin added PR #14882 fix(MachBufferFinalized): add unwind_info accessor to the merge queue.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 23 2026 at 22:57):

:check: cfallin merged PR #14882.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 23 2026 at 22:57):

cfallin removed PR #14882 fix(MachBufferFinalized): add unwind_info accessor from the merge queue.

Last updated: Oct 31 2026 at 23:03 UTC