Wasmtime GitHub notifications bot (Apr 08 2020 at 21:21): Wasmtime GitHub notifications bot (Apr 08 2020 at 21:21):abrown opened PR #1487 from fix-1471 to master:
This exposes the functionality of
fde::map_regon theTargetIsatrait, avoiding compilation errors on architectures where register mapping is not yet supported. The change is conditially compiled under theunwindfeature.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Apr 08 2020 at 21:21):abrown requested peterhuene for a review on PR #1487.
Wasmtime GitHub notifications bot (Apr 08 2020 at 21:30):abrown updated PR #1487 from fix-1471 to master:
This exposes the functionality of
fde::map_regon theTargetIsatrait, avoiding compilation errors on architectures where register mapping is not yet supported. The change is conditially compiled under theunwindfeature.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Apr 08 2020 at 21:36):peterhuene submitted PR Review.
Wasmtime GitHub notifications bot (Apr 08 2020 at 21:36):peterhuene submitted PR Review.
Wasmtime GitHub notifications bot (Apr 08 2020 at 21:36):peterhuene created PR Review Comment:
Clippy nit: unnecessary return statement.
Wasmtime GitHub notifications bot (Apr 08 2020 at 22:37):abrown updated PR #1487 from fix-1471 to master:
This exposes the functionality of
fde::map_regon theTargetIsatrait, avoiding compilation errors on architectures where register mapping is not yet supported. The change is conditially compiled under theunwindfeature.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Apr 09 2020 at 16:45):abrown merged PR #1487.
Last updated: Jan 09 2026 at 13:15 UTC